New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video download robustness improvements #5538

Closed
benjaoming opened this Issue Nov 13, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@benjaoming
Member

benjaoming commented Nov 13, 2017

Summary

  • Move fallback using Youtube-dl only trigger download_video and in case a thumbnail is missing, don't break.
  • Add tests specifically for the youtube-dl part. #5545
  • Ensure that a connection can be cut for up to 1 24 minutes per video without breaking downloads. #5545
  • Factor fle_utils out of everything that has to do with video downloads
  • Non-200 responses or other types of errors resulting in error pages being downloaded as mp4 files. #5545
  • Downloads that break while downloading should be retried, not removed completely from queue (now retried for ~24 minutes, then retried with youtube-dl) #5545

We have had sporadic missing thumbnails, which is explained in case there is a false positive URLNotFound because of connection errors fetching videos or thumbnails would trigger youtube-dl.

The following content has been found as an .mp4 file:

<html>
<head><title>502 Bad Gateway</title></head>
<body bgcolor="white">
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.4.6 (Ubuntu)</center>
</body>
</html>

This was referenced Nov 14, 2017

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Nov 20, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Nov 27, 2017

Member

Fixed in #5545!

Member

benjaoming commented Nov 27, 2017

Fixed in #5545!

@benjaoming benjaoming closed this Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment