New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve content pack assets from collectstatic(clear=True). #5074

Merged
merged 2 commits into from Apr 5, 2016

Conversation

Projects
None yet
2 participants
@aronasorman
Member

aronasorman commented Apr 5, 2016

Summary

Fixes #5069. Instead of blanket preserving all HTML files, we now specifically preserve the files found under perseus/ke/exercises, as these are the only HTML files that can't be collectstatic'ed (they come from content packs).

I ran manually tested the sdist made from this branch using the following procedures on an RPi 3:

  1. A fresh install
1. create a new virtualenv and ensure there's no .kalite dir
2. pip install ka-lite-static-0.16.1.tar.gz
3. kalite manage setup (downloading the content pack in the process)
4. load the kalite server and check for docs, and do some khan exercises

outcomes: docs link loads to 0.16, khan exercises load correctly.

  1. An upgrade from 0.15.1 to 0.16.1
1. pip install ka-lite-static-0.15.1.tar.gz with a current time of 04/03/2016
2. kalite manage setup

3. revert time to 03/28/1971
4. pip install ka-lite-static-0.16.1.tar.gz
5. kalite manage setup (skipping content pack installation)

result: static/js/distributed/ke/exercises had a timestamp of 04/03, docs links loaded 0.16.

@rtibbles @indirectlylit @MCGallaspy @jamalex

@aronasorman aronasorman added this to the 0.16.1 milestone Apr 5, 2016

@aronasorman aronasorman added the has PR label Apr 5, 2016

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Apr 5, 2016

Member

Nothing test breaking here. Merging.

Member

rtibbles commented Apr 5, 2016

Nothing test breaking here. Merging.

@rtibbles rtibbles merged commit 13adf62 into learningequality:0.16.x Apr 5, 2016

1 check was pending

ci/circleci CircleCI is running your tests
Details

@rtibbles rtibbles removed the has PR label Apr 5, 2016

This was referenced Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment