New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix critical bug in filtering attempt log collection request properly #5082

Merged
merged 1 commit into from Apr 12, 2016

Conversation

Projects
None yet
2 participants
@jamalex
Member

jamalex commented Apr 12, 2016

Critical bug fix for 0.16.2, as discussed with @aronasorman and @rtibbles.

Problem: data_model.get("exercise_id") was undefined, and hence when we made a request for attempt logs, it didn't filter by exercise, and returned the last 10 of any attempt logs from the user.

@radinamatic, I will send you an sdist momentarily, for testing.

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Apr 12, 2016

Member

This looks like the right fix to me.

Member

rtibbles commented Apr 12, 2016

This looks like the right fix to me.

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Apr 12, 2016

Member

Happy to merge when @radinamatic has confirmed fix.

Member

rtibbles commented Apr 12, 2016

Happy to merge when @radinamatic has confirmed fix.

@rtibbles rtibbles merged commit 81cd305 into learningequality:0.16.x Apr 12, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@rtibbles rtibbles removed the has PR label Apr 12, 2016

@aronasorman aronasorman referenced this pull request Apr 12, 2016

Merged

0.16.2 #5083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment