New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add woff2 files to MANIFEST and sdist #5110

Merged
merged 1 commit into from May 2, 2016

Conversation

Projects
None yet
2 participants
@benjaoming
Member

benjaoming commented Apr 30, 2016

Summary

As mentioned by @rifatbd in #5099, we are missing woff2 files. They need to be in our MANIFEST in order to end up in the sdist.

@benjaoming benjaoming self-assigned this Apr 30, 2016

@benjaoming benjaoming added this to the 0.16.4 milestone Apr 30, 2016

@benjaoming benjaoming added the has PR label Apr 30, 2016

@benjaoming benjaoming modified the milestones: 0.16.5, 0.16.4 Apr 30, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 30, 2016

Member

@rifatbd could you clarify what the missing fonts result in? Like e.g. components that aren't rendered because of this?

Member

benjaoming commented Apr 30, 2016

@rifatbd could you clarify what the missing fonts result in? Like e.g. components that aren't rendered because of this?

@rifatbd

This comment has been minimized.

Show comment
Hide comment
@rifatbd

rifatbd Apr 30, 2016

@benjaoming i will check and let you know..

rifatbd commented Apr 30, 2016

@benjaoming i will check and let you know..

@benjaoming benjaoming merged commit 583a37d into learningequality:0.16.x May 2, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@benjaoming benjaoming removed the has PR label May 2, 2016

@benjaoming benjaoming deleted the benjaoming:add-woff2-manifest branch May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment