New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat socket.error as if no server is running #5135

Merged
merged 1 commit into from Jun 4, 2016

Conversation

Projects
None yet
1 participant
@benjaoming
Member

benjaoming commented Jun 4, 2016

Summary

As reported by @harishbalachandran, trying to connect to a server defined in kalite.pid may cause a socket.error

Here, we catch it and thus assume that a socket.error indicates a running instance that's dead somehow or another network error that we don't need to worry about.

Issues addressed

#5132

@benjaoming benjaoming added the has PR label Jun 4, 2016

@benjaoming benjaoming changed the title from Treat socket.error as if the server isn't there #5132 to Treat socket.error as if no server is running Jun 4, 2016

@benjaoming benjaoming merged commit a5930e7 into learningequality:0.16.x Jun 4, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@benjaoming benjaoming removed the has PR label Jun 4, 2016

@benjaoming benjaoming deleted the benjaoming:socket-error branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment