New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pragma support #5225

Merged
merged 2 commits into from Jul 30, 2016

Conversation

Projects
None yet
2 participants
@aronasorman
Member

aronasorman commented Jul 28, 2016

Adds SQLite pragma support for content databases.

  • Upgrades our peewee version to add pragma support for SQLiteDatabase calls.
  • Adds a new setting in base.py, called CONTENT_DB_SQLITE_PRAGMAS, which should be a list of two-tuples. By default it's an empty list, but you can override it like so:
CONTENT_DB_SQLITE_PRAGMAS = [("journal_mode", "MEMORY"),
                             ("temp_store", "2")]

depending on your situation. See this link for a list of pragmas you can put here.

@aronasorman aronasorman added this to the 0.16.7 milestone Jul 28, 2016

@aronasorman aronasorman added the has PR label Jul 28, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 29, 2016

Member

@aronasorman tests are breaking, perhaps rebase to current 0.16.x will fix it...

Member

benjaoming commented Jul 29, 2016

@aronasorman tests are breaking, perhaps rebase to current 0.16.x will fix it...

@aronasorman

This comment has been minimized.

Show comment
Hide comment
@aronasorman

aronasorman Jul 29, 2016

Member

Rebased! Let's see what happens with the test now.

Member

aronasorman commented Jul 29, 2016

Rebased! Let's see what happens with the test now.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 30, 2016

Member

Looks good, let's assume updating Peewee is a good idea and have Pragma support.

Do you have any advice for the release notes, like a link that documents its usage?

Member

benjaoming commented Jul 30, 2016

Looks good, let's assume updating Peewee is a good idea and have Pragma support.

Do you have any advice for the release notes, like a link that documents its usage?

@benjaoming benjaoming merged commit 97f8f42 into learningequality:0.16.x Jul 30, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@benjaoming benjaoming removed the has PR label Jul 30, 2016

benjaoming added a commit to benjaoming/ka-lite that referenced this pull request Jul 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment