New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing return statement in user_agent helper function #5226

Merged
merged 1 commit into from Jul 29, 2016

Conversation

Projects
None yet
2 participants
@benjaoming
Member

benjaoming commented Jul 29, 2016

Summary

There was a missing return statement such that the user-agent header on various calls to our central hub was being set to None.

@arceduardvincent - it would be nice if you could test if this could be the cause of your mysterious pyrun crashes.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Have tests been written for the new code? If you're fixing a bug, write a regression test (or have a really good reason for not writing one... and I mean really good!)
  • Has documentation been written/updated?
  • New dependencies (if any) added to requirements file

Reviewer guidance

N/A

Issues addressed

Possibly #5211

@benjaoming benjaoming added the bug label Jul 29, 2016

@benjaoming benjaoming added this to the 0.16.7 milestone Jul 29, 2016

@benjaoming benjaoming self-assigned this Jul 29, 2016

@benjaoming benjaoming added the has PR label Jul 29, 2016

@benjaoming benjaoming referenced this pull request Jul 29, 2016

Closed

Fix Unclean shutdown in OS X installer. #5212

14 of 14 tasks complete
@arceduardvincent

This comment has been minimized.

Show comment
Hide comment
@arceduardvincent

arceduardvincent Jul 29, 2016

Member

@benjaoming yes I will take a look on this and test it.
Many thanks for the help.

Member

arceduardvincent commented Jul 29, 2016

@benjaoming yes I will take a look on this and test it.
Many thanks for the help.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 29, 2016

Member

Thanks @arceduardvincent !

Merging this now since the fix is obvious for other reasons (reporting version stats to our server!).

Member

benjaoming commented Jul 29, 2016

Thanks @arceduardvincent !

Merging this now since the fix is obvious for other reasons (reporting version stats to our server!).

@benjaoming benjaoming merged commit d579bc4 into learningequality:0.16.x Jul 29, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@benjaoming benjaoming removed the has PR label Jul 29, 2016

@benjaoming benjaoming deleted the benjaoming:missing-return-stm branch Jul 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment