New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wait times a lot shorter for silly BDD tests #5242

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
1 participant
@benjaoming
Member

benjaoming commented Aug 3, 2016

Summary

Enough facepalming. Make a couple of very slow tests faster and more reliable (they still failed randomly).

Cuts off 1:50 from test time on my local system.

Before:

1 feature passed, 0 failed, 0 skipped
7 scenarios passed, 0 failed, 0 skipped
42 steps passed, 0 failed, 0 skipped, 0 undefined
Took 2m22.849s

Now:

1 feature passed, 0 failed, 0 skipped
7 scenarios passed, 0 failed, 0 skipped
42 steps passed, 0 failed, 0 skipped, 0 undefined
Took 0m31.488s

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Have tests been written for the new code? If you're fixing a bug, write a regression test (or have a really good reason for not writing one... and I mean really good!)
  • Has documentation been written/updated?
  • New dependencies (if any) added to requirements file

Reviewer guidance

Issues addressed

@benjaoming benjaoming added the has PR label Aug 3, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 3, 2016

Member

On Circle... before:

screenshot from 2016-08-03 14 59 47

Now:

screenshot from 2016-08-03 14 59 57

Member

benjaoming commented Aug 3, 2016

On Circle... before:

screenshot from 2016-08-03 14 59 47

Now:

screenshot from 2016-08-03 14 59 57

@benjaoming benjaoming merged commit b861bf9 into learningequality:0.16.x Aug 3, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.01%) to 49.123%
Details

@benjaoming benjaoming removed the has PR label Aug 3, 2016

@benjaoming benjaoming deleted the benjaoming:fix-unreliable-bdd branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment