New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove watchify code from cli, it belongs in runserver (which works!) #5314

Merged
merged 1 commit into from Oct 3, 2016

Conversation

Projects
None yet
2 participants
@benjaoming
Member

benjaoming commented Oct 3, 2016

Summary

As the release notes will read, we have bin/kalite manage runserver --settings=kalite.project.settings.dev which does the job.

But furthermore, we should not expose developer options to users.

@benjaoming benjaoming added this to the 0.17.0 milestone Oct 3, 2016

@benjaoming benjaoming self-assigned this Oct 3, 2016

@benjaoming benjaoming added the has PR label Oct 3, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 3, 2016

Current coverage is 51.26% (diff: 50.00%)

Merging #5314 into develop will increase coverage by 0.11%

@@            develop      #5314   diff @@
==========================================
  Files           141        141          
  Lines          7468       7447    -21   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           3820       3818     -2   
+ Misses         3648       3629    -19   
  Partials          0          0          

Powered by Codecov. Last update 33497ae...8cc9380

codecov-io commented Oct 3, 2016

Current coverage is 51.26% (diff: 50.00%)

Merging #5314 into develop will increase coverage by 0.11%

@@            develop      #5314   diff @@
==========================================
  Files           141        141          
  Lines          7468       7447    -21   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           3820       3818     -2   
+ Misses         3648       3629    -19   
  Partials          0          0          

Powered by Codecov. Last update 33497ae...8cc9380

@benjaoming benjaoming merged commit eb068e0 into learningequality:develop Oct 3, 2016

2 of 3 checks passed

codecov/patch 50.00% of diff hit (target 51.15%)
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 51.26% (+0.11%) compared to 33497ae
Details

@benjaoming benjaoming removed the has PR label Oct 3, 2016

@benjaoming benjaoming deleted the benjaoming:remove-watchify-from-cli branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment