New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm CONFIG_PACKAGE and local_settings #5375

Merged
merged 4 commits into from Dec 23, 2016

Conversation

Projects
None yet
2 participants
@benjaoming
Member

benjaoming commented Dec 23, 2016

Summary

These settings raised exceptions in 0.16 and should be harmless to remove

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Have tests been written for the new code? If you're fixing a bug, write a regression test (or have a really good reason for not writing one... and I mean really good!)
  • Has documentation been written/updated?
  • New dependencies (if any) added to requirements file

Issues addressed

#4830

@benjaoming benjaoming added this to the 0.17.0 milestone Dec 23, 2016

@benjaoming benjaoming self-assigned this Dec 23, 2016

@benjaoming benjaoming added the has PR label Dec 23, 2016

@benjaoming benjaoming changed the title from Rm configpackage and local_settings to Rm CONFIG_PACKAGE and local_settings Dec 23, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 23, 2016

Member

@jtamiace @aronasorman - I've moved Nalanda customization to kalite.project.settings.nalanda - I'm not sure how their deployments work, but this file can perhaps help maintain their settings in simple common place.

Member

benjaoming commented Dec 23, 2016

@jtamiace @aronasorman - I've moved Nalanda customization to kalite.project.settings.nalanda - I'm not sure how their deployments work, but this file can perhaps help maintain their settings in simple common place.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 23, 2016

Current coverage is 51.46% (diff: 80.30%)

Merging #5375 into develop will decrease coverage by 0.28%

@@            develop      #5375   diff @@
==========================================
  Files           142        143     +1   
  Lines          7604       7553    -51   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           3935       3887    -48   
+ Misses         3669       3666     -3   
  Partials          0          0          

Powered by Codecov. Last update 4cd701b...3169669

codecov-io commented Dec 23, 2016

Current coverage is 51.46% (diff: 80.30%)

Merging #5375 into develop will decrease coverage by 0.28%

@@            develop      #5375   diff @@
==========================================
  Files           142        143     +1   
  Lines          7604       7553    -51   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           3935       3887    -48   
+ Misses         3669       3666     -3   
  Partials          0          0          

Powered by Codecov. Last update 4cd701b...3169669

@benjaoming benjaoming merged commit d964d40 into learningequality:develop Dec 23, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 80.30% of diff hit (target 51.74%)
Details
codecov/project Absolute coverage decreased by -0.28% but relative coverage increased by +28.55% compared to 4cd701b
Details

@benjaoming benjaoming removed the has PR label Dec 23, 2016

@benjaoming benjaoming deleted the benjaoming:rm-configpackage-local_settings branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment