New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traceback to error 500 page #5405

Merged
merged 3 commits into from Feb 10, 2017

Conversation

Projects
None yet
3 participants
@benjaoming
Member

benjaoming commented Feb 10, 2017

Summary

Due to various issues reported, I'm trying to affirm that device registration works through a bit of fumbling.

  • Add an additional test case to clear that online presence is correctly detected.
  • Add a proper error traceback so we can find out what the initial reports were about (since logs had no info)

Issues addressed

#5401
#5123

@benjaoming benjaoming added the has PR label Feb 10, 2017

@benjaoming benjaoming added this to the 0.17.0 milestone Feb 10, 2017

@benjaoming benjaoming self-assigned this Feb 10, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 10, 2017

Codecov Report

Merging #5405 into 0.17.x will increase coverage by 0.04%.

@@            Coverage Diff            @@
##           0.17.x   #5405      +/-   ##
=========================================
+ Coverage   51.76%   51.8%   +0.04%     
=========================================
  Files         143     143              
  Lines        7499    7499              
=========================================
+ Hits         3882    3885       +3     
+ Misses       3617    3614       -3
Impacted Files Coverage Δ
kalite/distributed/views.py 61.14% <ø> (+1.91%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019139e...34b91fa. Read the comment docs.

codecov-io commented Feb 10, 2017

Codecov Report

Merging #5405 into 0.17.x will increase coverage by 0.04%.

@@            Coverage Diff            @@
##           0.17.x   #5405      +/-   ##
=========================================
+ Coverage   51.76%   51.8%   +0.04%     
=========================================
  Files         143     143              
  Lines        7499    7499              
=========================================
+ Hits         3882    3885       +3     
+ Misses       3617    3614       -3
Impacted Files Coverage Δ
kalite/distributed/views.py 61.14% <ø> (+1.91%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019139e...34b91fa. Read the comment docs.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Feb 10, 2017

Member

New error page (before clicking textarea)

screenshot from 2017-02-10 20-29-44

After clicking text area:

screenshot from 2017-02-10 20-30-23

Member

benjaoming commented Feb 10, 2017

New error page (before clicking textarea)

screenshot from 2017-02-10 20-29-44

After clicking text area:

screenshot from 2017-02-10 20-30-23

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Feb 10, 2017

Contributor

😍

Contributor

radinamatic commented Feb 10, 2017

😍

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Feb 10, 2017

Member

Merging this, because then at least we can know about the other issue on Mac/Windows that we haven't been able to troubleshoot through logs etc.

Member

benjaoming commented Feb 10, 2017

Merging this, because then at least we can know about the other issue on Mac/Windows that we haven't been able to troubleshoot through logs etc.

@benjaoming benjaoming merged commit e1649a6 into learningequality:0.17.x Feb 10, 2017

@benjaoming benjaoming removed the has PR label Feb 10, 2017

@benjaoming benjaoming changed the title from Additional fixes for device registration to Add traceback to error 500 page Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment