New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent underneath body element from scrolling when scroll the sideba… #5410

Merged
merged 1 commit into from Mar 17, 2017

Conversation

Projects
None yet
4 participants
@66eli77
Contributor

66eli77 commented Feb 14, 2017

…r or sidebar-fade area

Summary

Fix the issue #5407
Only tested on Mac chrome and android chrome browsers, would need more testing on different devices, especially on Linux where the issue is originally discovered.

TODO

  • Tested on Linux
  • Tested on Firefox
  • Tested on Safari
  • Tested on Edge
  • Tested on IE10
@66eli77

This comment has been minimized.

Show comment
Hide comment
@66eli77

66eli77 Feb 14, 2017

Contributor

A separate issue, seems clicking on sidebar item not working on IE9. @benjaoming is kalite 0.17 supposed to support IE9?

Contributor

66eli77 commented Feb 14, 2017

A separate issue, seems clicking on sidebar item not working on IE9. @benjaoming is kalite 0.17 supposed to support IE9?

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 14, 2017

Codecov Report

Merging #5410 into 0.17.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.17.x    #5410   +/-   ##
=======================================
  Coverage   51.76%   51.76%           
=======================================
  Files         143      143           
  Lines        7499     7499           
=======================================
  Hits         3882     3882           
  Misses       3617     3617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e030914...0c9bf72. Read the comment docs.

codecov-io commented Feb 14, 2017

Codecov Report

Merging #5410 into 0.17.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.17.x    #5410   +/-   ##
=======================================
  Coverage   51.76%   51.76%           
=======================================
  Files         143      143           
  Lines        7499     7499           
=======================================
  Hits         3882     3882           
  Misses       3617     3617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e030914...0c9bf72. Read the comment docs.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Mar 17, 2017

Member

It sounds like from @nedrichards that it's been tested for Edge, so I've marked it as Done.

Merging now, this will be part of the 0.17.1 release.

Member

benjaoming commented Mar 17, 2017

It sounds like from @nedrichards that it's been tested for Edge, so I've marked it as Done.

Merging now, this will be part of the 0.17.1 release.

@benjaoming benjaoming merged commit 5845d3c into learningequality:0.17.x Mar 17, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e030914...0c9bf72
Details
codecov/project 51.76% remains the same compared to e030914
Details

@benjaoming benjaoming removed the has PR label Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment