From 760decf163190ef16aa42dc7bf18a25ceb1740c7 Mon Sep 17 00:00:00 2001 From: Richard Tibbles Date: Wed, 2 Aug 2017 16:17:14 -0700 Subject: [PATCH] Use && instead of ||. --- kolibri/plugins/user/assets/src/views/sign-in-page/index.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kolibri/plugins/user/assets/src/views/sign-in-page/index.vue b/kolibri/plugins/user/assets/src/views/sign-in-page/index.vue index 0cf9ad567a5..296fc42b079 100644 --- a/kolibri/plugins/user/assets/src/views/sign-in-page/index.vue +++ b/kolibri/plugins/user/assets/src/views/sign-in-page/index.vue @@ -160,7 +160,7 @@ }); }, setSuggestionTerm(newVal, oldVal) { - if (newVal !== null || typeof newVal !== 'undefined') { + if (newVal !== null && typeof newVal !== 'undefined') { // Only check if defined or not null if (newVal.length < 3) { // Don't search for suggestions if less than 3 characters entered @@ -190,7 +190,7 @@ }, fillUsername(username) { // Only do this if we have been passed a non-null value - if (username !== null || typeof username !== 'undefined') { + if (username !== null && typeof username !== 'undefined') { this.username = username; this.showDropdown = false; }