-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Loader Misallignment and Flickering #11921
Fix Loader Misallignment and Flickering #11921
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, the improvement of the icon alignment is definitely noticeable! One small issue I noticed is a console error related to setting disableDefaultTransition
to string "true" instead of a Boolean value.
Thanks @LianaHarris360 i overlooked it, fixed it in the new commit. |
kolibri/plugins/learn/assets/src/my_downloads/views/DownloadsList/index.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thank you!
f63cb78
into
learningequality:release-v0.16.x
Summary
This PR fixes Loader misalignment in some places, and also resolves flickering of loader in download page.
loader_align.mp4
References
Fix #11884