Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Loader Misallignment and Flickering #11921

Merged

Conversation

iskipu
Copy link
Contributor

@iskipu iskipu commented Feb 26, 2024

Summary

This PR fixes Loader misalignment in some places, and also resolves flickering of loader in download page.

loader_align.mp4

References

Fix #11884

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: small labels Feb 26, 2024
Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, the improvement of the icon alignment is definitely noticeable! One small issue I noticed is a console error related to setting disableDefaultTransition to string "true" instead of a Boolean value.

@iskipu
Copy link
Contributor Author

iskipu commented Mar 1, 2024

Thanks @LianaHarris360 i overlooked it, fixed it in the new commit.

Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thank you!

@LianaHarris360 LianaHarris360 merged commit f63cb78 into learningequality:release-v0.16.x Mar 4, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants