Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing private channels in import workflow #3929

Merged

Conversation

jonboiser
Copy link
Contributor

Summary

Fixes #3926

Reviewer guidance

  1. Re-do scenario in Imported channel not showing at the channel list. #3926.

References


Contributor Checklist

  • Contributor has fully tested the PR manually
  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If there are any front-end changes, before/after screenshots are included
  • If this is an important user-facing change, PR or related issue has a 'changelog' label

Reviewer Checklist

  • Automated test coverage is satisfactory
  • Reviewer has fully tested the PR manually
  • PR has been tested for accessibility regressions
  • External dependencies files were updated (yarn and pip)
  • Documentation is updated
  • Link to diff of internal dependency change is included
  • CHANGELOG.rst is updated for high-level changes
  • Contributor is in AUTHORS.rst

@jonboiser jonboiser added the TODO: needs review Waiting for review label Jun 28, 2018
@jonboiser jonboiser added this to the 0.10.0 milestone Jun 28, 2018
@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #3929 into release-v0.10.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.10.x    #3929   +/-   ##
================================================
  Coverage            77.61%   77.61%           
================================================
  Files                  217      217           
  Lines                 9309     9309           
  Branches              1173     1173           
================================================
  Hits                  7225     7225           
  Misses                1830     1830           
  Partials               254      254

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2feb...fd861c1. Read the comment docs.

Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't actually able to reproduce the original issue but was still able to import after testing

@indirectlylit indirectlylit merged commit 11fed12 into learningequality:release-v0.10.x Jun 29, 2018
@jonboiser jonboiser deleted the available-channels branch July 3, 2018 19:05
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants