This repository was archived by the owner on Jan 9, 2021. It is now read-only.
enable hot module reloading, clarify dist file types, bump version #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(changing dist file names is a breaking change)
indirectlylit
added a commit
to indirectlylit/kolibri
that referenced
this pull request
Dec 1, 2018
Previously we were always using the dev version. This change relies on learningequality/vue-intl#22
rtibbles
approved these changes
Dec 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows Vue hot reloading to work: when the
developmentbuild is used and the locale isen, we return the default message rather than the one available from our locale resources. This unfortunately assumes that the default messages are in English; a future improvement might be to have this be configurable.This change also clarifies the dist files by giving them
devandprodqualifiers. It's possible for example that we might want to create minimizeddevfiles or fullprodfiles, and now we have this option.Made a major version bump because changing the names of dist files are a breaking change.