Skip to content

Conversation

@paranoicsan
Copy link
Collaborator

This pull request updates the Ruby version to 3.2.9, which includes several performance enhancements and bug fixes, as well as updating several gems that are used in the project. This update also includes a new PostgreSQL version in the Dockerfile, which is useful for the development team to ensure compatibility with the latest features and security updates.

Additionally, this pull request includes some refactoring of code related to empty collection declarations, as well as updating RBS declarations.

The changes made by this pull request are designed to improve the performance and compatibility of the project, making it easier for developers to work on the codebase and ensuring that it remains stable and secure over time.

@paranoicsan paranoicsan requested a review from shlag3n August 3, 2025 02:25
@paranoicsan paranoicsan self-assigned this Aug 3, 2025
@paranoicsan paranoicsan added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 3, 2025
Copy link
Collaborator

@shlag3n shlag3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, added minor comment re dockerfile and wkhtmltopdf

&& rm -r /var/lib/apt/lists/* /var/cache/apt/*

# install specific wkhtmltopdf binary
RUN apt-get update -qqy \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need wkhtmltopdf here and not chrome?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because lcms-engine doesn't depends on it. But still does on wkhtnltopdf 🤷🏻‍♂️

- Update some gems, including rubocop. Refactoring code for that.
- Bump PostgreSQL to 15 in Dockerfile
- Added some steep directives to correctly handle empty collection declaration.
- Updated RBS declarations
@paranoicsan paranoicsan force-pushed the ruby-3.2.9 branch 3 times, most recently from b0ba155 to 171b82f Compare August 4, 2025 00:13
@paranoicsan paranoicsan merged commit d84db2d into ruby-3-upgrade Aug 4, 2025
1 check passed
@paranoicsan paranoicsan deleted the ruby-3.2.9 branch August 4, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants