Remove withRouter

[josephsavona]

What is withRouter? In general it's helpful to introduce as few new concepts at a time. I already know how Relay works, and I was immediately confused by withRouter, so I imagine people reading will be too.

[schickling]

I agree! @Brene / @lvarayut is this needed here?

[lvarayut]

Totally agree with Joseph. I don't think we need it.

[schickling]

@lvarayut we just need to make sure it's aligned with the working example project.

[marktani]

I remember @Brene having a distinct reason for including withRouter. In any case I agree that at the moment having it here just introduces a lot of confusion. I think we can add a sentence or two on withRouter at this step, and explain it further down the road in the Router chapter.

Would love to hear @Brene's opinion on that :)

[renebrandel]

I'm a bit overwhelmed today. I'll look over it tomorrow ;-)

[renebrandel]

@josephsavona seems to be right. It looks like some "old" legacy code and we should remove it from all the examples. Previously we used this.props.router.push('...'). But I've replaced everything with Link. That's the issue. @marktani do you have time to change it in the pokedex example?

[marktani]

Ok will do that 👍

[alexedev]

withRouter is still used starting from these examples https://learnrelay.org/queries/working-with-fragments

[marktani]

Thanks for pointing this out, fixed it in 294f4d1.