ReSharper version of VS2010 themes #3

Merged
merged 7 commits into from Nov 14, 2012

Conversation

4 participants
@brantb
Contributor

brantb commented Apr 18, 2011

Here's a R#ized version of the VS2010 themes. I also colored the tool windows (Output, Console, Immediate).

VS2010 and R# have a slightly incompatible method of coloring variables and types. When R#'s syntax highlighting is enabled, the "User Types (Foo)" color settings are ignored in favor of the "ReSharper Foo Identifier" settings. I changed a few the existing User Types colors to match the default R# ones.

I'm not sure how compatible these configs are with 2008/2005. I assume if you imported them it would just ignore the unknown color definitions, but I'm not sure which ones are missing in those versions.

brantb added some commits Apr 15, 2011

Added ReSharper colors to solarized-dark.
Some colors for user types were changed as well so make them fit better with R#'s identifier coloring, and tool windows (Output/Immediate/Console) are colored as well.
@brantb

This comment has been minimized.

Show comment
Hide comment
@brantb

brantb Apr 18, 2011

Contributor

Also, I'm not entirely happy with "ReSharper Field Identifier" and "ReSharper Method Identifier". It uses base1 which is almost indistinguishable from base0 (at least in non-bold Consolas 10pt). I'd rather use something between base1 and base2, but that'd be breaking away from the 16-color Solarized palette.

Contributor

brantb commented Apr 18, 2011

Also, I'm not entirely happy with "ReSharper Field Identifier" and "ReSharper Method Identifier". It uses base1 which is almost indistinguishable from base0 (at least in non-bold Consolas 10pt). I'd rather use something between base1 and base2, but that'd be breaking away from the 16-color Solarized palette.

@leddt

This comment has been minimized.

Show comment
Hide comment
@leddt

leddt Apr 19, 2011

Owner

Wow thanks a lot for this. I'll test it as soon as possible.

As for base1, I believe it's intended to be bolded, which makes it stand-out nicely from non-bold base0.

Owner

leddt commented Apr 19, 2011

Wow thanks a lot for this. I'll test it as soon as possible.

As for base1, I believe it's intended to be bolded, which makes it stand-out nicely from non-bold base0.

Tweaked R# colors
* Changed fields from base1/nobold to base0/bold
* Changed methods from base0/nobold to base1/bold
* Changed mutable local vars from base0/bold to base1/nobold
@brantb

This comment has been minimized.

Show comment
Hide comment
@brantb

brantb Apr 19, 2011

Contributor

A few more tweaks after playing with it a bit:

  • Changed fields from base1/nobold to base0/bold
  • Changed methods from base0/nobold to base1/bold
  • Changed mutable local vars from base0/bold to base1/nobold

Here's a screenshot with and without R#'s "Color identifiers" setting enabled, and a gist with the source code I used to test.

Contributor

brantb commented Apr 19, 2011

A few more tweaks after playing with it a bit:

  • Changed fields from base1/nobold to base0/bold
  • Changed methods from base0/nobold to base1/bold
  • Changed mutable local vars from base0/bold to base1/nobold

Here's a screenshot with and without R#'s "Color identifiers" setting enabled, and a gist with the source code I used to test.

Tweaked R#'s ASP.NET MVC colors
Action/area/controller names in strings are underlined blue, views are underlined green.
@NJAldwin

This comment has been minimized.

Show comment
Hide comment
@NJAldwin

NJAldwin Aug 15, 2011

I really like this fork, but is it only for 2010? In 2008, things seem to work okay, but the ReSharper Todo Item's default (Blue) makes it very hard to read.

I really like this fork, but is it only for 2010? In 2008, things seem to work okay, but the ReSharper Todo Item's default (Blue) makes it very hard to read.

@brantb

This comment has been minimized.

Show comment
Hide comment
@brantb

brantb Aug 16, 2011

Contributor

I've only tested it in VS2010. VS2008 may lack color definitions for certain types of text, or use a different name for them. Unfortunately I don't have VS2008 installed so I can't give it a try myself -- as you discovered, it should mostly work, but it'll probably need some tweaking.

Contributor

brantb commented Aug 16, 2011

I've only tested it in VS2010. VS2008 may lack color definitions for certain types of text, or use a different name for them. Unfortunately I don't have VS2008 installed so I can't give it a try myself -- as you discovered, it should mostly work, but it'll probably need some tweaking.

@NJAldwin

This comment has been minimized.

Show comment
Hide comment
@NJAldwin

NJAldwin Aug 16, 2011

Right. If I do do any tweaking, I'll submit a pull request. I use 2008 at work and 2010 at home, so I'll try to get them to be as similar as possible.

Right. If I do do any tweaking, I'll submit a pull request. I use 2008 at work and 2010 at home, so I'll try to get them to be as similar as possible.

@leddt

This comment has been minimized.

Show comment
Hide comment
@leddt

leddt Aug 16, 2011

Owner

Hi. I have not been available to review the pull requests lately for personal reasons. I don't think I'll have time to maintain this repository. If either of you would like to become collaborators on this, please let me know.

Owner

leddt commented Aug 16, 2011

Hi. I have not been available to review the pull requests lately for personal reasons. I don't think I'll have time to maintain this repository. If either of you would like to become collaborators on this, please let me know.

@couellet

This comment has been minimized.

Show comment
Hide comment
@couellet

couellet Jun 13, 2012

Wow, in VS2010 this pull request is sick! Good job leddt and brantb!

Wow, in VS2010 this pull request is sick! Good job leddt and brantb!

@leddt

This comment has been minimized.

Show comment
Hide comment
@leddt

leddt Nov 14, 2012

Owner

Hey I really want to merge this in but there is a non-trivial merge conflict with the vssettings files and I'm really short on time. Think you can take a look ?

Owner

leddt commented Nov 14, 2012

Hey I really want to merge this in but there is a non-trivial merge conflict with the vssettings files and I'm really short on time. Think you can take a look ?

Merge remote-tracking branch 'upstream/master' into resharper
Conflicts:
	vs2010/solarized-dark.vssettings
	vs2010/solarized-light.vssettings
@brantb

This comment has been minimized.

Show comment
Hide comment
@brantb

brantb Nov 14, 2012

Contributor

@leddt That ought to do it.

Contributor

brantb commented Nov 14, 2012

@leddt That ought to do it.

leddt added a commit that referenced this pull request Nov 14, 2012

Merge pull request #3 from brantb/resharper
ReSharper version of VS2010 themes

@leddt leddt merged commit 580fcbd into leddt:master Nov 14, 2012

@leddt

This comment has been minimized.

Show comment
Hide comment
@leddt

leddt Nov 14, 2012

Owner

Great! By the way, thank you for your contributions.

Owner

leddt commented Nov 14, 2012

Great! By the way, thank you for your contributions.

@brantb

This comment has been minimized.

Show comment
Hide comment
@brantb

brantb Nov 14, 2012

Contributor

Whoops, somehow that merge went bad...

Contributor

brantb commented Nov 14, 2012

Whoops, somehow that merge went bad...

@leddt

This comment has been minimized.

Show comment
Hide comment
@leddt

leddt Nov 14, 2012

Owner

Indeed. Seems the github ui can't be trusted.

Owner

leddt commented Nov 14, 2012

Indeed. Seems the github ui can't be trusted.

@leddt

This comment has been minimized.

Show comment
Hide comment
@leddt

leddt Nov 14, 2012

Owner

I think I fixed it but make sure to update your branches

Owner

leddt commented Nov 14, 2012

I think I fixed it but make sure to update your branches

@leddt leddt referenced this pull request Nov 14, 2016

Closed

Add resharper support #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment