dnsmasq: reload configuration by signal #1601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the hostname in /etc/config/system is modified the dnsmasq should also get triggered to rewrite/reload the config. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Send a signal with procd for dnsmasq if service should reread his config. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If the system name was changed then the "dnsmasq" must be restarted to rewrite his config with the new hostname. Adding "/etc/config/system" to the reload trigger will trigger "dnsmasq" on "/etc/config/system" change.
To apply the new configuration "dnsmasq" must get restarted with start/stop to rewrite the configuration and then also restart a new instance to serve the new configuration. If reload_service was triggered then only sending a signal to dnsmasq to reload his config for the running service is enough. No new instance is required to serve the new configuration.
I have added this functionality one year ago, but this introduce errors on service reload and was reverted.
ADD:
TDT-AG@854459a#diff-f65b4391dc02a776f873f8e933742458
REVERT:
TDT-AG@93227e4#diff-f65b4391dc02a776f873f8e933742458