Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
dnsmasq: decrease the amount of individual sites listed in log #797
This PR is related to #638 as it tries to tackle the same challenge, log spam from nxdomain based adblock.
I don't want to push all dnsmasq logging into /dev/null or so, but would like to decrease log spam related to blocked ad sites.
By default the 30 first servers are listed individually to system log, and then a count of the remaining items. With e.g. a NXDOMAIN based adblock service, dnsmasq lists 30 unnecessary ad sites every time when dnsmasq evaluates the list (twice at startup). What is worse, the actual nameservers are evaluated last and get included in the "remaining items" total and their details are not displayed.
Run-tested with ipq806x/R7800 at r3324-174ce4c56d
Example output at router startup when adblock gets loaded:
I submitted it upstream as http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2017q1/011206.html
Let's see what happens.
This has been applied to the upstream dnsmasq as http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=3e2496fb16fb78cb95fffdac80f967310a34b1fa
So there is no need to take this patch separately into LEDE.