dnsmasq: decrease the amount of individual sites listed in log #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should definitely go upstream. LGTM. |
|
I submitted it upstream as http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2017q1/011206.html Let's see what happens. |
By default 30 first servers are listed individually to system log, and then a count of the remaining items. With e.g. a NXDOMAIN based adblock service, dnsmasq lists 30 unnecessary ad sites every time when dnsmasq evaluates the list. But the actual nameservers in use are evaluated last and are not displayed as they get included in the "remaining items" total. Handle the "local addresses only" separately and list only a few of them. Remove the "local addresses only" from the general count. Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
This has been applied to the upstream dnsmasq as http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=3e2496fb16fb78cb95fffdac80f967310a34b1fa So there is no need to take this patch separately into LEDE. |
|
And I included it in #816 'cos it missed test3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #638 as it tries to tackle the same challenge, log spam from nxdomain based adblock.
I don't want to push all dnsmasq logging into /dev/null or so, but would like to decrease log spam related to blocked ad sites.
By default the 30 first servers are listed individually to system log, and then a count of the remaining items. With e.g. a NXDOMAIN based adblock service, dnsmasq lists 30 unnecessary ad sites every time when dnsmasq evaluates the list (twice at startup). What is worse, the actual nameservers are evaluated last and get included in the "remaining items" total and their details are not displayed.
Run-tested with ipq806x/R7800 at r3324-174ce4c56d
Example output at router startup when adblock gets loaded: