Add Twitter widget to index page #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmichael
added a commit
that referenced
this pull request
Dec 2, 2014
Add Twitter widget to index page
Member
|
Nice. Should it be wider ? Three full length tweets get clipped & require scrolling:
Also you could set a width on the container so that the body text does not use the full width while the widget is loading, causing "pop-in". |
Member
Author
|
Thanks for merging. Good point about the "pop-in" I'll fiddle around with some height and width settings and issue another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set the height of the twitter widget to 500px so it approximately matches height of the current page content.
This is a Pull Request for Issue #12.