fix: Return the correct indent when shiftwidth==0#137
Merged
Conversation
Currently, when 'shiftwidth' is set to 0, GetLedgerIndent always returns 0, making it very ineffective. But when 'shiftwidth' is set to 0, vim falls back to 'tabstop'. The help entry of 'shiftwidth' recommends to use the shiftwidth function to get the effective value of 'shiftwidth', which is what this fix does.
alerque
approved these changes
Nov 27, 2022
alerque
left a comment
alerque
left a comment
Member
There was a problem hiding this comment.
Thanks for tracking this down and taking the time to contribute. LGTM.
Contributor
Author
|
You are welcome, thanks for all the work maintaining this plugin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when 'shiftwidth' is set to 0, GetLedgerIndent always returns
0, making it very ineffective.
But when 'shiftwidth' is set to 0, vim falls back to 'tabstop'. The help
entry of 'shiftwidth' recommends to use the shiftwidth function to get
the effective value of 'shiftwidth', which is what this fix does.