Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mismatched recon transactions table to top of recon screen #1818

Closed
einhverfr opened this issue Jul 24, 2016 · 2 comments
Closed

Move mismatched recon transactions table to top of recon screen #1818

einhverfr opened this issue Jul 24, 2016 · 2 comments
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect wontfix Issue acknowledged, but won't be addressed by the project
Milestone

Comments

@einhverfr
Copy link
Member

https://sourceforge.net/p/ledger-smb/feature-requests/288/

The issue is that the mismatched table requires more attention than the cleared transactions table.

@einhverfr einhverfr added type:enhancement Proposed improvement, new feature, or extension -- not a defect bite-sized Deemed a good starting point for new contributors to learn about the code base. labels Jul 24, 2016
@einhverfr einhverfr modified the milestones: 1.5, 1.5-rc1 Jul 24, 2016
@einhverfr
Copy link
Member Author

I think if we are going to do this for 1.5 we should do it for rc1 for maximum opportunity for feedback.. We can always push this back if we want to. @ehuelsmann you originally filed the ticket on sourceforge. Anything to add to this?

@einhverfr einhverfr added the wontfix Issue acknowledged, but won't be addressed by the project label Jul 24, 2016
@einhverfr
Copy link
Member Author

Thinking through this some more, the reason why the table is where it is today is that the mismatched and uncleared transactions are more closely related, so it is better, I think, to have those two tables closer. (Usually you want to correlate a mismatched transaction with what is going on in the uncleared portion, which is at the bottom).

I see two options.

The first is we keep things the way they are now.
The second is we re-order them with the mismatched, then uncleared, then cleared.

The disadvantage of option 2 is that the heading information is closely tied to the cleared transactions so we would be sacrificing approval review ease for data entry ease. I guess my vote would be to close this wontfix (which I am doing now).

If you want further discussion though, feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect wontfix Issue acknowledged, but won't be addressed by the project
Projects
None yet
Development

No branches or pull requests

1 participant