New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5: Layout of single payment screen regression #1917

Closed
ehuelsmann opened this Issue Jul 31, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@ehuelsmann
Member

ehuelsmann commented Jul 31, 2016

The data entry fields in the single payment screen are much too wide; much wider than they were in 1.4. This seems to be a CSS issue.

@ehuelsmann ehuelsmann added this to the 1.5-rc2 milestone Jul 31, 2016

@einhverfr einhverfr modified the milestones: 1.5-rc2, 1.5.0 Aug 19, 2016

@ehuelsmann ehuelsmann modified the milestones: 1.5.1, 1.5.0 Nov 20, 2016

@ehuelsmann

This comment has been minimized.

Show comment
Hide comment
@ehuelsmann

ehuelsmann Nov 20, 2016

Member

Moving to 1.5.1 -- not important enough to hold up a 1.5.0 release for.

Member

ehuelsmann commented Nov 20, 2016

Moving to 1.5.1 -- not important enough to hold up a 1.5.0 release for.

@ehuelsmann

This comment has been minimized.

Show comment
Hide comment
@ehuelsmann

ehuelsmann Jan 7, 2017

Member

Analysing this issue, it's because of the "neutralize default width of 15em" at the top of 'global.css'.

Without that bit, the invoice looks awful. With that bit, the single payments screen is messed up...

Member

ehuelsmann commented Jan 7, 2017

Analysing this issue, it's because of the "neutralize default width of 15em" at the top of 'global.css'.

Without that bit, the invoice looks awful. With that bit, the single payments screen is messed up...

@ehuelsmann ehuelsmann modified the milestones: 1.5.1, 1.5.2 Jan 8, 2017

@ehuelsmann ehuelsmann modified the milestones: 1.5.2, 1.5.3 Jan 23, 2017

@ehuelsmann ehuelsmann modified the milestones: 1.5.3, 1.5.4 Feb 19, 2017

@ehuelsmann ehuelsmann modified the milestones: 1.5.4, 1.5.8 May 26, 2017

ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Jun 11, 2017

* Fix #1917: Single payment entry screen regression due to Dojo move
The changes in the payment2.html file mostly just add CSS classes;
without the re-indentation the file wasn't readable enough for me to
make sense and be able to create this change. Sorry for the low
signal-to-noise ratio (by including the space-reindentation).

ehuelsmann added a commit that referenced this issue Jun 11, 2017

Merge pull request #2901 from ehuelsmann/master-issue-1917
* Fix #1917: Single payment entry screen regression due to Dojo move

ehuelsmann added a commit that referenced this issue Jun 11, 2017

Merge pull request #2902 from ehuelsmann/1.5-issue-1917
* Fix #1917: Single payment entry screen regression due to Dojo move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment