1.4: printed invoice always includes 'Paid' row #2569

Closed
ehuelsmann opened this Issue Jan 21, 2017 · 0 comments

Projects

None yet

1 participant

@ehuelsmann
Member

Even if the Paid row contains a zero amount (formatted as "0,00"), the paid row is included in the output. The template tests for IF paid, which is true, since only empty strings and zero evaluate to false (in this context it doesn't matter that empty arrays do too).

@ehuelsmann ehuelsmann added this to the 1.4 milestone Jan 21, 2017
@ehuelsmann ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Jan 21, 2017
@ehuelsmann ehuelsmann * Fix #2569 and fix #2568: invoice template improvements
Note: includes other invoice improvements;
 * localize 'Credit Invoice' instead of two words
 * add Total row in invoice after taxes
 * rename 'Balance Due' to Balance after 'Paid'
ea5ea66
@ehuelsmann ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Jan 21, 2017
@ehuelsmann ehuelsmann * Fix #2569 and fix #2568: invoice template improvements
Note: includes other invoice improvements;
 * localize 'Credit Invoice' instead of two words
 * add Total row in invoice after taxes
 * rename 'Balance Due' to Balance after 'Paid'

Conflicts:
	templates/demo/invoice.html
	templates/demo/invoice.tex
	templates/demo_with_images/invoice.html
	templates/demo_with_images/invoice.tex
	templates/xedemo/invoice.tex
edc0433
@ehuelsmann ehuelsmann added a commit that closed this issue Jan 21, 2017
@ehuelsmann ehuelsmann * Fix #2569 and fix #2568: invoice template improvements
Note: includes other invoice improvements;
 * localize 'Credit Invoice' instead of two words
 * add Total row in invoice after taxes
 * rename 'Balance Due' to Balance after 'Paid'
54e3834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment