New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Don't do access control on contacts for database owners and superusers #2584

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
2 participants
@ehuelsmann
Member

ehuelsmann commented Jan 23, 2017

As pointed out on our chat channel, we don't want dbadmins to be superusers;
with this change, we're another step closer to not requiring superuser
level for the dbadmin.

Conflicts:
sql/modules/Roles.sql

* Don't do access control on contacts for database owners and superusers
As pointed out on our chat channel, we don't want dbadmins to be superusers;
with this change, we're another step closer to not requiring superuser
level for the dbadmin.

Conflicts:
	sql/modules/Roles.sql
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 23, 2017

Coverage Status

Coverage remained the same at 10.85% when pulling c8493de on ehuelsmann:1.4-improve-contact-access-control into 742f738 on ledgersmb:1.4.

coveralls commented Jan 23, 2017

Coverage Status

Coverage remained the same at 10.85% when pulling c8493de on ehuelsmann:1.4-improve-contact-access-control into 742f738 on ledgersmb:1.4.

@ehuelsmann ehuelsmann merged commit 1fa9cca into ledgersmb:1.4 Jan 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 10.85%
Details

@ehuelsmann ehuelsmann deleted the ehuelsmann:1.4-improve-contact-access-control branch Jan 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment