Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue i18n extract #6350

Merged
merged 6 commits into from Jan 9, 2022
Merged

Vue i18n extract #6350

merged 6 commits into from Jan 9, 2022

Conversation

ylavoie
Copy link
Contributor

@ylavoie ylavoie commented Jan 8, 2022

This PR add scripts to extract the Vue strings to allow internationalization.

  • Vue text is extracted in JSON form and integrated to our current set, to allow translation with Transifex. Care is taken to set references to ease translator job.
  • Translated text is exported to JSON format to allow compilation for Vue UI. Untranslated text is removed from JSON to allow defaulting to english

@ylavoie ylavoie marked this pull request as draft January 8, 2022 02:11
@ylavoie ylavoie force-pushed the vue-i18n-extract branch 2 times, most recently from ca36c64 to dc882aa Compare January 8, 2022 17:33
@ylavoie ylavoie marked this pull request as ready for review January 8, 2022 17:33
@ylavoie ylavoie marked this pull request as draft January 8, 2022 17:48
@ylavoie ylavoie force-pushed the vue-i18n-extract branch 3 times, most recently from 821c8b8 to 61b9315 Compare January 9, 2022 07:06
@ylavoie ylavoie marked this pull request as ready for review January 9, 2022 07:06
locale/po/ar_EG.po Outdated Show resolved Hide resolved
cpanfile Outdated Show resolved Hide resolved
xt/01.2-deps.t Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bit more checking and changing to be done re my prior comments.

Copy link
Member

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to figure out the utils/devel/ part. Got it now.

Big +1 and thanks for the change!

@ylavoie ylavoie merged commit 889f69d into ledgersmb:master Jan 9, 2022
@ylavoie ylavoie deleted the vue-i18n-extract branch January 9, 2022 22:28
ylavoie added a commit to ylavoie/LedgerSMB that referenced this pull request Jan 15, 2022
* Add Vue extraction to JSON & PO

Add conversion script from PO to JSON

* Update PO & JSON

* Pull-in optionally localized text

* Fix dependency check

* Move 'File::Grep' to development only

* Remove npm vue extraction script in favor of 'utils/devel/extract=vue-template-translations.sh'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants