feat(ci): add comprehensive tests + build job + expanded CI#1
Merged
Conversation
- Add pytest + 21 tests for all CLI commands (using CliRunner + mocks) - New jobs in CI: lint (now with format check + tests dir), test (matrix 3.10-3.12), build (uv build + smoke install) - pyproject: [project.optional-dependencies] dev, pytest config - Dynamic __version__ from importlib.metadata (single source of truth) - Update README dev instructions - Bump/fix CI actions already done previously All checks (ruff, mypy, pytest, build) now pass locally and in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tests: 21 new tests in
tests/test_cli.pyusingtyper.testing.CliRunner+ heavy mocking (subprocess,shutil.which,platform,builtins.open,typer.confirm). Covers:run_commanderror pathsTests are cross-platform (no real pacman/tar/sudo needed).
CI expansion (
.github/workflows/ci.yml):lintjob now also runsruff format --check, lintstests/, installs via.[dev]testjob with matrix on Python 3.10 / 3.11 / 3.12 (pytest)buildjob:uv build, verify dist/ artifacts, smoke-install the wheel and exercise thesyskitentrypointTooling:
pyproject.toml:[project.optional-dependencies] dev = [ruff, mypy, pytest, build],[tool.pytest.ini_options]__version__viaimportlib.metadata(no more hard-coded in 3 places)All local checks (ruff, mypy, pytest, build smoke) ✅
Why
Closes the "add tests, a build job, or other things" request. Makes the project much more robust and the CI actually useful (previously only lint that was red).
Test plan
ruff check . && ruff format --check .mypy src/pytest(21 tests)python -m build+ wheel install +syskit versionNext ideas (roadmap items)
Ready for review!