Added Choose/When/Otherwise components inspired by XSL #5
Conversation
|
Now that the package is growing we should consider adding Prettier to keep the style consistent! |
| @@ -45,3 +45,16 @@ export function ElseIf(props: { | |||
| }): React.ReactNode; | |||
|
|
|||
| export function Else(props: { children: React.ReactNode }): React.ReactNode; | |||
|
|
|||
| export function Choose(props: { | |||
| children: When | Otherwise; | |||
There was a problem hiding this comment.
I'm not a typescript wizard yet so I don't know what this should be, but I think you want to allow an ReactElement or Array of ReactElement of When | Otherwise type
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Couldn't this block just be:
find(child => child.type === When && child.props.test || child.type === Otherwise)
| it('renders only the first when of which test is truthy', () => { | ||
| expectRenderToEqual( | ||
| <Choose> | ||
| <When test={true !== false}> |
| @@ -28,3 +28,6 @@ declare function For<O: Object>({| | |||
| declare function If({ case: any, children: React$Node }): React$Node; | |||
| declare function ElseIf({ case: any, children: React$Node }): React$Node; | |||
| declare function Else({ children: React$Node }): React$Node; | |||
| declare function Choose({ children: React$Node<typeof When> | React$Node<typeof Otherwise>}): React$Node; | |||
There was a problem hiding this comment.
Does this line work in a try flow?
I'd have expected React$Node<When | Otherwise>
| <When test={someCondition}> | ||
| This will only be shown if someCondition is truthy. | ||
| </When> | ||
| <When case={otherCondition}> |
|
From an API standpoint, |
|
Following #12, I think I'm going to close this one, but I still like this feature from XSL! Maybe we should have |
|
I already started using the If component and now I gotta remove it :( |
|
I would be down for a react conditionals lib |
|
I'm in the process of claiming |
Added super useful Choose/When/Otherwise components as discussed on Twitter