Lee Byron leebyron

Organizations

@facebook
leebyron commented on issue facebook/immutable-js#412
@leebyron

Strange. CI claims all tests pass. I'll look into it.

@leebyron
Bad links on documentation
leebyron commented on issue facebook/immutable-js#418
@leebyron

Sorry all, looks like I got ahead of the CDN and the JS file for the docs didn't load. I just fixed it, should work for you now.

@leebyron
  • @leebyron 2ca815a
    temporary down version while cdn catches up
leebyron commented on issue facebook/immutable-js#407
@leebyron

Did I managed to make a compelling case for RecordLists that are the key to having polymorphic functions without workarounds described earlier Th…

@leebyron
Incorrect version of Immutable.js on http://facebook.github.io/immutable-js
leebyron commented on issue facebook/immutable-js#414
@leebyron

Thanks for the heads up! Fixed

@leebyron
leebyron closed pull request facebook/immutable-js#307
@leebyron
Update link to Immutable.js.ts
leebyron commented on pull request facebook/immutable-js#307
@leebyron

Fixed in latest docs

@leebyron
leebyron commented on pull request facebook/immutable-js#367
@leebyron

Fixed in latest docs

leebyron closed pull request facebook/immutable-js#367
@leebyron
Typos in URLs.
@leebyron
leebyron commented on issue facebook/immutable-js#401
@leebyron

This is by design, sort is unavailable within withMutations. A future API change will hopefully make this far more clear as it's a very common poin…

leebyron commented on issue facebook/immutable-js#402
@leebyron

Good suggestion

leebyron commented on issue facebook/immutable-js#407
@leebyron

Your rationale is sound here. I totally agree that having a clean way to parse JSON into Immutable collections is really valuable. The trick is get…

@leebyron
  • @leebyron 2b0880a
    merge/union dont work correctly inside withMutations when the mutable…
@leebyron
set.union() fails inside withMutations
@leebyron
leebyron merged pull request facebook/immutable-js#371
@leebyron
Add key as third argument to custom merger
1 commit with 33 additions and 24 deletions
leebyron commented on pull request facebook/immutable-js#371
@leebyron

Seems like a pretty obvious win. Thanks for your patience, this is great.

leebyron closed pull request facebook/immutable-js#314
@leebyron
Instantiate classes with 'new', now that ES6 requires it.
leebyron commented on pull request facebook/immutable-js#314
@leebyron

Closing this PR since new isn't the correct semantic for factory functions.

leebyron commented on pull request facebook/immutable-js#314
@leebyron

I am going to move away from classes in v4. They will officially be factory functions and the syntax will make that more clear. Also as part of the…

leebyron commented on pull request facebook/immutable-js#379
@leebyron

This should live in a separate sort of thing. Cursor is meant to be a very transparent view over a Map or a List, not to represent a new kind of da…

@leebyron
OrderedMap can't be created from List of Lists
@leebyron
some API methods not available on cursor