feat-013: KYC Verification (Mock Provider)#3
Closed
leecampbell-codeagent wants to merge 6 commits into
Closed
Conversation
…at-004) - Multi-step onboarding wizard (welcome, role selection, profile, preferences, completion) - Account domain entity extended with onboarding_step, role, profile, and notification preference fields - Domain event emission to event store on onboarding completion and profile updates - API endpoints: GET /me, PATCH /me/onboarding, PATCH /me, PATCH /me/preferences - PgAccountRepository updated with findById and update methods - InMemoryEventStore and PgEventStoreAdapter implemented - Frontend: OnboardingWizard with StepProgress, RoleCards, ToggleSwitch components - Settings pages: /settings/profile and /settings/preferences - Onboarding guard redirects users to /onboarding if not complete - 260 tests passing (132 backend + 128 frontend) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add 401 unauthenticated tests for all 4 account API endpoints - Fix preferences_updated event payload to include categories_changed array - Wrap account update + event append in shared database transaction (Edge Case LeeCampbell#17) - Introduce TransactionPort and PgTransactionAdapter for transactional DB operations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Exploratory review: PASS (code-review based, all 8 US verified) - Security review: PASS (0 critical/high findings) - Audit: PASS (all 3 failures resolved in iteration 2) - CI/CD: PASS — add GitHub Actions workflow (lint, typecheck, test, build, audit) - Fix 34 lint/a11y errors: semantic HTML in onboarding components (label+input for radio group, section for region, output for status), biome format fixes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- KycVerification entity with 9-state lifecycle and ALLOWED_TRANSITIONS guard - KycPort, StoragePort, KycRepository port interfaces - MockKycAdapter (auto-approve), MockStorageAdapter, PgKycRepository (parameterised SQL) - KycAppService: submit, status query, admin unlock; emits domain events - API: POST /kyc/submit, GET /kyc/status, POST /kyc/admin/unlock/:accountId (admin-only) - New migration: add front_document_ref, back_document_ref, submitted_at to kyc_verifications - Frontend: /settings/verification page with all 9 status states, 3-second polling - KycStatusBadge component, useKycStatus (with polling), useSubmitKyc hooks - 344 tests passing (192 backend + 152 frontend) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… length - All 4 quality checks PASS (security, audit, exploratory, CI/CD) — first pass - Add .max(512) to front_document_ref and back_document_ref Zod schema (MED-001) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
leecampbell-codeagent
force-pushed
the
ralph/feat-004-account-registration-onboarding
branch
from
9bc3091 to
774b35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KycVerificationentity with 9-state lifecycle:not_verified → pending → verified | pending_resubmission | in_manual_review → rejected | locked | expired | reverification_requiredALLOWED_TRANSITIONSmap enforced viaassertTransition()— invalid transitions throwInvalidKycTransitionError; auto-lock after 5 failuresKycPort,StoragePort,KycRepositoryport interfaces;MockKycAdapter(auto-approve),PgKycRepository(parameterised SQL)KycAppService: submit verification, status query, admin unlock (role-checked at two layers)POST /kyc/submit(auth),GET /kyc/status(auth),POST /kyc/admin/unlock/:accountId(admin-only)20260305000002_add_kyc_document_refs.sql/settings/verificationpage with all 9 status states;KycStatusBadge; 3-second polling when pending;useKycStatus,useSubmitKychooksStacked on:
ralph/feat-004-account-registration-onboarding— merge feat-004 PR first.Quality Gate
Reports
.claude/reports/feat-013-exploratory.md.claude/reports/feat-013-security.md.claude/reports/feat-013-audit.md.claude/reports/feat-013-cicd.md🤖 Generated with Claude Code