Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BlockScope of "Slop::Commands#new" is influenced by arity number #81

Merged
merged 1 commit into from Sep 16, 2012

Conversation

Projects
None yet
2 participants
Contributor

kachick commented Sep 16, 2012

Is this expected behavior?

ruby 1.9.3p194 (2012-04-20 revision 35410) [i686-linux]

p Slop::Commands.new {||p __id__}.__id__  #=> same
p Slop::Commands.new {|_|p __id__}.__id__ #=> differrent

@leejarvis leejarvis pushed a commit that referenced this pull request Sep 16, 2012

Lee Jarvis Merge pull request #81 from kachick/fix/commands-new_block_scope_unde…
…r_arity_number

BlockScope of "Slop::Commands#new" is influenced by arity number
f16c105

@leejarvis leejarvis merged commit f16c105 into leejarvis:master Sep 16, 2012

1 check passed

default The Travis build passed
Details
Owner

leejarvis commented Sep 16, 2012

Looks good, thanks!

@kachick kachick added a commit to kachick/slop that referenced this pull request Sep 16, 2012

@kachick kachick fix block-scope of "Slop.new" and other constructors(e.g: Slop.parse)…
…, these are influenced by arity number. this problem is same as #81
89215e4

@leejarvis leejarvis pushed a commit that referenced this pull request Sep 17, 2012

Lee Jarvis Merge pull request #82 from kachick/fix/slop-constructors_block_scope…
…_influenced_by_arity_number

BlockScope of Slop constructors, they are influenced by arity number (same as #81)
977d837

@leejarvis leejarvis added a commit that referenced this pull request Oct 15, 2012

@leejarvis leejarvis Revert "fix block-scope of "Slop.new" and other constructors(e.g: Slo…
…p.parse), these are influenced by arity number. this problem is same as #81"

This reverts commit 89215e4.

Conflicts:
	test/slop_test.rb
2c60751

@kachick kachick added a commit to kachick/slop that referenced this pull request Oct 20, 2012

@kachick kachick Revert "fix block-scope of "Slop::Commands#new" is influenced by arit…
…y number"

This reverts commit dafe660.
(issue/#81)
88c2407

@leejarvis leejarvis added a commit that referenced this pull request Oct 20, 2012

@leejarvis leejarvis Merge pull request #91 from kachick/fix/revert_#81_and_specify_expect…
…ed_behavior_of_Commands.new

Revert #81 and specify expected behavior of Commands.new
cf49b09

@kachick kachick deleted the kachick:fix/commands-new_block_scope_under_arity_number branch Dec 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment