Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for Samesite=None attribute #237

Merged
merged 1 commit into from Jan 13, 2020
Merged

adding support for Samesite=None attribute #237

merged 1 commit into from Jan 13, 2020

Conversation

@Dur09
Copy link
Contributor

Dur09 commented Jan 13, 2020

Description: As per the google chrome updates here (https://www.chromestatus.com/feature/5633521622188032), we need to explicitly set SameSite=None cookie. But CGI::Cookie.pm currently lacks this support.
This PR adds the support for SameSite=None cookie and is successfully tested at my end.

@leejo leejo merged commit 3445049 into leejo:master Jan 13, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leejo

This comment has been minimized.

Copy link
Owner

leejo commented Jan 13, 2020

Looks good 👍 - I'll add a couple of unit tests and then send to CPAN.

@leejo

This comment has been minimized.

Copy link
Owner

leejo commented Jan 13, 2020

v4.45 on its way to CPAN

@Dur09

This comment has been minimized.

Copy link
Contributor Author

Dur09 commented Jan 14, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.