Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still secretly needs Test::Deep #17

Closed
kentfredric opened this issue Nov 17, 2017 · 1 comment
Closed

Still secretly needs Test::Deep #17

kentfredric opened this issue Nov 17, 2017 · 1 comment

Comments

@kentfredric
Copy link

https://metacpan.org/source/LEEJO/CGI-Fast-2.12/Changes#L33-35

2.05 2014-12-11
[TESTING]
remove useless use of Test::Deep in tests

https://github.com/leejo/cgi-fast/blob/master/t/003_env_pollution.t#L7

use Test::More tests => 5;
use Test::Deep;

META.json since 2.006 has not declared TEST_REQUIRES of Test::Deep

https://metacpan.org/diff/file?target=LEEJO%2FCGI-Fast-2.06%2F&source=LEEJO%2FCGI-Fast-2.05#META.json

@@ -22,10 +22,7 @@
    },
    "prereqs" : {
       "build" : {
-         "requires" : {
-            "Test::Deep" : "0.11",
-            "Test::More" : "0"
-         }
+         "requires" : {}
       },
       "configure" : {
          "requires" : {}
@@ -33,10 +30,8 @@
       "runtime" : {
          "requires" : {
             "CGI" : "4",
+            "Carp" : "0",
             "FCGI" : "0.67",
-            "File::Spec" : "0.82",
-            "Test::Deep" : "0.11",
-            "Test::More" : "0.98",
             "if" : "0",
             "perl" : "5.008001"
          }

The lack of failures is held together by the skeleton effect of Makefile.PL restoring those dependencies in the generated MYMETA.json combined with dynamic_config: 1

https://github.com/leejo/cgi-fast/blob/master/Makefile.PL#L19-L22

    TEST_REQUIRES   => {
        'Test::More'      => 0,
        'Test::Deep'      => 0.11,
        'File::Temp'      => 0,
    },

But it should still be considered a regression that tests unconditionally need Test::Deep, and neither META.json or META.yml stipulate Test::Deep in any way.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Nov 17, 2017
This is caused by an upstream packaging issue

Bug: leejo/cgi-fast#17
Package-Manager: Portage-2.3.8, Repoman-2.3.3
@leejo leejo closed this as completed in d6d74d8 Nov 17, 2017
@leejo
Copy link
Owner

leejo commented Nov 17, 2017

Thanks! v2.13 will be on its way to CPAN shortly.

NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this issue Nov 17, 2017
This is caused by an upstream packaging issue

Bug: leejo/cgi-fast#17
Package-Manager: Portage-2.3.8, Repoman-2.3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants