Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 0 commit comments
  • 1 contributor
Commits on Jun 12, 2009
Jonathan del Strother Fix leak on -[TTURLRequestLoader cancel:] bf49af8
Commits on Jul 03, 2009
Jonathan del Strother SDKROOT -> 3.0, DEPLOYMENT_TARGET -> 2.2.1
Having a nightmare persuading my app to run on both 2.2.1 & 3.0 without hardcoding these settings in three20's xcodeproj
Not quite ready to move to 3.0-only yet...
83ff6e5
Showing with 5 additions and 2 deletions.
  1. +1 −0 src/TTURLRequestQueue.m
  2. +4 −2 src/Three20.xcodeproj/project.pbxproj
View
1 src/TTURLRequestQueue.m
@@ -241,6 +241,7 @@ - (BOOL)cancel:(TTURLRequest*)request {
if (_connection) {
TTNetworkRequestStopped();
[_connection cancel];
+ [_connection release];
_connection = nil;
}
return NO;
View
6 src/Three20.xcodeproj/project.pbxproj
@@ -775,10 +775,11 @@
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
HEADER_SEARCH_PATHS = .;
+ IPHONEOS_DEPLOYMENT_TARGET = 2.2.1;
ONLY_ACTIVE_ARCH = YES;
OTHER_LDFLAGS = "-ObjC";
PREBINDING = NO;
- SDKROOT = iphonesimulator2.2;
+ SDKROOT = iphoneos3.0;
};
name = Debug;
};
@@ -790,9 +791,10 @@
GCC_C_LANGUAGE_STANDARD = c99;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
+ IPHONEOS_DEPLOYMENT_TARGET = 2.2.1;
OTHER_LDFLAGS = "-ObjC";
PREBINDING = NO;
- SDKROOT = iphonesimulator2.2;
+ SDKROOT = iphoneos3.0;
};
name = Release;
};

No commit comments for this range

Something went wrong with that request. Please try again.