Permalink
Commits on Feb 3, 2012
  1. First pass at laying out organisations page, still requires a fair am…

    …ount of work but is closer.
    
      - Also generalised js helper to set heights equal to largest when floated (name change of plugin).
    Jason Cale committed Feb 3, 2012
  2. Don't show ministers in the management team.

    Classic error.
    lazyatom committed Feb 3, 2012
  3. Tighten up the organisation hierarchy.

    This commit contains a few related small changes:
    
    - Re-order the organisation navigation
      (https://www.pivotaltracker.com/story/show/24406295)
    - Change references from 'board members' to 'management team'
      (https://www.pivotaltracker.com/story/show/24406329)
    - Link to the 'Management Team' from the 'About' page rather than the
      main organisation nav
      (https://www.pivotaltracker.com/story/show/24406329)
    - Link to the 'Management Team' from underneath the top civil servant
      (https://www.pivotaltracker.com/story/show/24424937)
    lazyatom committed Feb 3, 2012
  4. Stop news images appearing too small.

    We're not exactly sure why this wasn't working, since `#content img`
    has `width: 100%` as a rule, which should trigger it to be 100% of its
    container.
    
    The new rule is perhaps a bit more explicit; the `max-width` of the
    image is set to 100% of its container, and the specific `width` of the
    image is set to `inherit`, which should also set it to be the width of
    the container.
    
    Huh. Weird.
    lazyatom committed Feb 3, 2012
  5. Use the existing helper.

    DRY FTW.
    lazyatom-and-floehopper committed Feb 3, 2012
  6. Default search_index format to underscored class name

    This is almost always what we want.
    tomstuart committed Feb 3, 2012
  7. Index supporting pages with their own format

    These were previously masquerading as their associated document
    in order to get the policy icon, but now there's an explicit
    supporting page icon (albeit the same as the policy icon at the
    moment) we can give them a distinct format.
    
    If supporting pages ever get associated with other types of
    document it might be desirable to revert this change. For now
    it's better to keep things simple and unsurprising.
    tomstuart committed Feb 3, 2012
  8. Fix supporting page header markup

    The styles expect this to be inside a section.page_header.
    tomstuart committed Feb 3, 2012
  9. Refactor announcement logic into a presenter.

    This makes the view and controller much simpler, and also makes it
    easier to extract shared logic between the today and last 7 days
    collections.
    lazyatom-and-floehopper committed Feb 3, 2012
  10. Only feature news and speeches which have images.

    At the moment, speeches don't have images so they're never actually featured.
    
    I'd like to extract this logic into the `Announcements` class next, and move much of the testing to tests against that class too.
    lazyatom-and-floehopper committed Feb 3, 2012
  11. Stop displaying attachment filename.

    We had a problem with long attachment filenames (without spaces) not
    wrapping. Rather than fix the word wrapping problem, we decided to
    no longer display the filename because, since we now have attachment
    titles, it isn't very useful any more.
    floehopper committed Feb 3, 2012
  12. Allow creation of new document editions when the parent is invalid

    The parent can become invalid if a validation has been added since it was published.
    tomafro committed Feb 3, 2012
  13. Prevent invalid documents from being published.

    It is possible for an existing document to be invalid if additional validations are added after the edition is first saved.  In this case, publishing should fail.
    tomafro committed Feb 3, 2012
  14. Simplify sort order testing.

    It's overkill to test the negative, i.e. that the documents are not
    sorted by published_at, and it is sufficient to test the the documents
    are sorted by first_published_at.
    floehopper committed Feb 3, 2012
  15. Add country descriptions

    tomstuart committed Feb 3, 2012
  16. Lock to Rake 0.9.2, rather than 0.9.2.2

    We had originally allowed the use of 0.9.2.2 so that we could use Ruby
    1.9.3 to develop against, but a change in rummager
    (alphagov/rummager@c7171b0) locking
    it to 0.9.2 explicitly, in combination with the fact that both apps
    are deployed on the same machine, means that we have to revert this to
    avoid Passenger freaking out.
    
    Rake 0.9.2 is the version which puppet ensures, and so rather than try to retain this flexibility, it is easier to move Whitehall into line with the strict constraint.
    
    Note that this means we can no longer develop using Ruby 1.9.3 locally.
    lazyatom-and-floehopper committed Feb 3, 2012
  17. If policy notes aren't present on the page then we shouldn't link the…

    … update at time.
    Jason Cale committed Feb 3, 2012
Commits on Feb 2, 2012