Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find fields by label #60

Merged
merged 1 commit into from Dec 6, 2012

Conversation

Projects
None yet
2 participants
@kberridge
Copy link
Contributor

commented Dec 5, 2012

I'm really happy with the behavior of this feature, but not entirely thrilled with the code... I was forced to significantly refactor findByFunction and break it into multiple other functions and the names of those functions aren't great. Also had to do a lot of null checking that feels really out of place in F#. I'd appreciate any feedback you might have.

@lefthandedgoat

This comment has been minimized.

Copy link
Owner

commented Dec 5, 2012

You want to assert the value of the input following a specific label? Sounds reasonable.

Hmmm what if you first look and see if the text begins with # . or an html element and see if its a css selector, and if its not, then assume its a label's text and go from there. Does that get you where you want?

Nulls probably wouldn't exist in F# if it wasn't for interop with other CLR languages. I will think more about this tomorrow.

@kberridge

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2012

I thought about that as a performance optimization, but then realized a label could start with any of those characters ['.', '#', 'input', ...].

@lefthandedgoat

This comment has been minimized.

Copy link
Owner

commented Dec 5, 2012

I will accept and build tonight. Thanks for the contribution!

lefthandedgoat added a commit that referenced this pull request Dec 6, 2012

@lefthandedgoat lefthandedgoat merged commit af6b766 into lefthandedgoat:master Dec 6, 2012

@lefthandedgoat

This comment has been minimized.

Copy link
Owner

commented Dec 6, 2012

Version 0.6.2 built and pushed with this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.