Find fields by label#60
Merged
lefthandedgoat merged 1 commit intolefthandedgoat:masterfrom Dec 6, 2012
Merged
Conversation
Owner
|
You want to assert the value of the input following a specific label? Sounds reasonable. Hmmm what if you first look and see if the text begins with # . or an html element and see if its a css selector, and if its not, then assume its a label's text and go from there. Does that get you where you want? Nulls probably wouldn't exist in F# if it wasn't for interop with other CLR languages. I will think more about this tomorrow. |
Contributor
Author
|
I thought about that as a performance optimization, but then realized a label could start with any of those characters ['.', '#', 'input', ...]. |
Owner
|
I will accept and build tonight. Thanks for the contribution! |
Owner
|
Version 0.6.2 built and pushed with this feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really happy with the behavior of this feature, but not entirely thrilled with the code... I was forced to significantly refactor findByFunction and break it into multiple other functions and the names of those functions aren't great. Also had to do a lot of null checking that feels really out of place in F#. I'd appreciate any feedback you might have.