Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round is undefined when calling inWords() with ordinary_share_subscription, series_aa_sg #237

Open
jobchong opened this Issue Nov 22, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@jobchong
Copy link
Member

jobchong commented Nov 22, 2016

Have not determined whether this is a template issue or whether the security type issued by both agreements are breaking something somewhere.

Logs stop here for both templates:
[16-11-21 19:59:23:243 PST] templates fillTemplate: starting ordinary_share_subscription (01 - Ordinary Share Subscription Agreement for Mister Moneybags moneybags@example.com)

All associated document XML except for the investment agreement itself will generate in both instances.

@mengwong

This comment has been minimized.

Copy link
Member

mengwong commented Nov 25, 2016

successfully reproduced! Running against a fresh copy of the Demo Master, using the Ordinary Shares Subscription Agreement template, under Tools / Script Editor, the Execution log shows:


<schedule_header xname="schedule_shareholding">Shareholding Structure</schedule_header>

<schedule_parts>Existing Shareholders</schedule_parts>
]) [0 seconds]
[16-11-25 08:09:14:227 PST] Execution failed: TypeError: Cannot call method "inWords" of undefined. (line 421, file "captable", project "legaleseMain") [14.571 seconds total runtime]
@mengwong

This comment has been minimized.

Copy link
Member

mengwong commented Nov 25, 2016

ok, i have solved this for the ordinary_share_subscription template but i have not solved it for the other sg aa template – will need to look at that later.

i think we need to deprecate the data.parties.shareholder approach everywhere, and access via round.() instead. I have started to update the documentation in the google-apps readme as well.

jobchong added a commit that referenced this issue Feb 3, 2017

@jobchong

This comment has been minimized.

Copy link
Member Author

jobchong commented Feb 3, 2017

Should I assume that wherever data.parties.shareholder is called to list current members of the company, the members are equivalent to old investors? If so, I'll replace the rest of the occurrences with getOldInvestors()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.