Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Home Page Content #33

Closed
madiedgar opened this issue Oct 25, 2019 · 10 comments

Comments

@madiedgar
Copy link
Member

@madiedgar madiedgar commented Oct 25, 2019

Home Page Content Clean Up

There are a couple of typo's in the home page that need to be cleaned up!

  • In the "Stay In The Know" section at the bottom of the page, welcomed is misspelled.
  • In the "Develop" section, change the first sentence: Innovation and creativity should never be lost in translation, that’s why we created Legesher! to Innovation, creativity, and collaboration should never be lost in translation, that’s why we created Legesher!
@shahkv95

This comment has been minimized.

Copy link
Contributor

@shahkv95 shahkv95 commented Oct 25, 2019

@madiedgar I am working on this issue..!

@madiedgar

This comment has been minimized.

Copy link
Member Author

@madiedgar madiedgar commented Oct 25, 2019

Amazing!! THank you @shahkv95

@shahkv95

This comment has been minimized.

Copy link
Contributor

@shahkv95 shahkv95 commented Oct 25, 2019

I have created the PR @madiedgar . Please accept it .
Thank you.

@Yutyo

This comment has been minimized.

Copy link

@Yutyo Yutyo commented Oct 25, 2019

I am working too. I have found more errors and made improvements to consider btw.

madiedgar added a commit that referenced this issue Oct 25, 2019
Updated index.html - Solved #33
🎉 thank you @shahkv95 for your contribution!
@shahkv95

This comment has been minimized.

Copy link
Contributor

@shahkv95 shahkv95 commented Oct 25, 2019

I have created one more PR @madiedgar . I have made few more standard correction.
Please accept it and merge the PR.
Thank you.

@Yutyo

This comment has been minimized.

Copy link

@Yutyo Yutyo commented Oct 25, 2019

Can you accept my pull request too?

shahkv95 added a commit to shahkv95/legesher-dot-io that referenced this issue Oct 27, 2019
@Yutyo

This comment has been minimized.

Copy link

@Yutyo Yutyo commented Oct 28, 2019

Hi, why you have labeled my pull request as invalid?

@madiedgar

This comment has been minimized.

Copy link
Member Author

@madiedgar madiedgar commented Oct 28, 2019

Hey @Yutyo 👋, part of creating a quality pull request is that the contribution pushes the project forward. I've been receiving multiple pull requests that aren't aligned with the purpose of the project so the best way to make sure your contribution serves us all is to first create an issue detailing the proposed changes. If accepted, then you can proceed to completing the pull request. Hope this helps clarify!

BlackSou added a commit to BlackSou/legesher-dot-io that referenced this issue Nov 1, 2019
@BlackSou

This comment has been minimized.

Copy link

@BlackSou BlackSou commented Nov 1, 2019

I h made few more standard correction.
Please accept it and merge the PR.
Thank you!
@madiedgar

@madiedgar madiedgar added this to In progress in Version: Beta Nov 15, 2019
@madiedgar madiedgar moved this from In progress to Review in progress in Version: Beta Nov 16, 2019
@madiedgar madiedgar moved this from Review in progress to In progress in Version: Beta Nov 16, 2019
@madiedgar

This comment has been minimized.

Copy link
Member Author

@madiedgar madiedgar commented Nov 16, 2019

Closing this issue as it was resolved in multiple pr's 🎉

@madiedgar madiedgar closed this Nov 16, 2019
Version: Beta automation moved this from In progress to Done Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.