Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date grouping not working in all languages #465

Closed
CarlosRebolledo opened this issue Jan 28, 2021 · 8 comments
Closed

Date grouping not working in all languages #465

CarlosRebolledo opened this issue Jan 28, 2021 · 8 comments
Milestone

Comments

@CarlosRebolledo
Copy link

Estimado,

Desconozco la razón, pero la agrupación de correos por fecha no funciona.

Desactive extensiones de terceros para ver si era el problema y sigue igual.

Adjunto captura y report

2021-01-28 Desktop-screenshot

Simplify v.2.1.20

Configuration:
simplify lowDensity ca3 caI caL cfC cfI cfO cfQ cfR cfU composeActions composeFormat debug hideSignatures bgOff minimizeChat showChat aAX newUI lightTheme defaultTheme nPane dateGroup inMsg appMenuOpen

Browser:
:5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.104 Safari/537.36; 1536px by 824px (100% zoom)

@leggett
Copy link
Owner

leggett commented Jan 28, 2021

Looks like it is broken for Spanish. Thanks for flagging this. I'll see what I can do.

@CarlosRebolledo
Copy link
Author

Ok. Gracias 👍

@leggett leggett changed the title Agrupación de correos por fecha no funciona Option to change favicon not working Jan 28, 2021
@leggett leggett changed the title Option to change favicon not working Date grouping not working in some languages Jan 28, 2021
@leggett
Copy link
Owner

leggett commented Jan 29, 2021

Ok, I have this working in a random set of languages now (Spanish, Dutch, Italian, French, Portuguese, Chinese, and Korean). Will ship with 2.1.21.

I'll close this when I support all the languages Gmail supports... but it will take a while to go through each one (I have to change Gmail's interface language and then run a script I wrote across a sample of emails to see how Gmail writes the date).

@leggett leggett added this to the v2.1 milestone Jan 29, 2021
@leggett leggett changed the title Date grouping not working in some languages Date grouping not working in all languages Jan 29, 2021
@leggett
Copy link
Owner

leggett commented Jan 29, 2021

The other thing I should do at some point is translate the strings used for labeling the different sections:

  • Yesterday
  • This week
  • This month
  • Last month
  • Name of 2 months ago (will probably just skip this one in non-english)
  • Earlier

@CarlosRebolledo
Copy link
Author

Gracias Michel

Abrazos y éxito

@leggett
Copy link
Owner

leggett commented Feb 2, 2021

Ok, I added more languages. Calling this done for now. I haven't translated the other strings I use (will create a separate ticket for internationalization in general)

  • Chinese (China)
  • Chinese (Hong Kong)
  • Chinese (Taiwan)
  • Czech
  • Danish
  • Dutch
  • English (United Kingdom)
  • English (United States)
  • Finnish
  • French
  • French (Canadian)
  • German
  • Greek
  • Hebrew
  • Hungarian
  • Indonesian
  • Italian
  • Japanese
  • Korean
  • Norwegian
  • Polish
  • Portuguese (Brazil)
  • Portuguese (Portugal)
  • Russian
  • Spanish
  • Spanish (Latin America)
  • Swedish
  • Turkish
  • Ukrainian

@leggett leggett closed this as completed Feb 2, 2021
@leggett
Copy link
Owner

leggett commented Feb 2, 2021

P.S. Those languages are all the ones used by current users on Chrome according to my Chrome Web Store Dashboard.

@CarlosRebolledo
Copy link
Author

Big Michael !!!

Excellent and again congratulations

I hope I can load my payment soon

A hug from Chile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants