Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with other extensions #83

Open
dragoncalledk opened this issue Apr 25, 2019 · 20 comments

Comments

Projects
None yet
7 participants
@dragoncalledk
Copy link

commented Apr 25, 2019

Hi! Love this, but it has a few very minor layout issues with the Copper extension. Here's a screenshot so you can see what I am talking about: https://1drv.ms/u/s!ApSeon_rCZ7cpbAkt6LPostsoJUmiQ

Any way to fix that?

@ebeldner

This comment has been minimized.

Copy link

commented Apr 25, 2019

@dragoncalledk, getting an error when I click on the link.

I'm also having the same issue but with a Boomerang extension:
Screen Shot 2019-04-25 at 11 49 32 am

@leggett

This comment has been minimized.

Copy link
Owner

commented Apr 25, 2019

Sorry but compatibility with other extensions isn't something I can support. There are too many of them and some change often.

If/when things settle down, I might take a look at some of the popular ones and see if I can find a pattern to how they integrate themselves but nothing soon.

I do support add-ons (installed through Gmail > Settings gear > Get add-ons).

@leggett leggett closed this Apr 25, 2019

@leggett

This comment has been minimized.

Copy link
Owner

commented Apr 25, 2019

With Gmail now supporting scheduled sending and their reminders on emails that you sent but didn't get a reply on... do you still need Boomerang?

@leggett leggett changed the title Compatibility with Copper, other extensions Compatibility with other extensions Apr 25, 2019

@leggett leggett added this to the Someday maybe milestone Apr 25, 2019

@leggett leggett added the enhancement label Apr 25, 2019

@leggett

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2019

I'm going to start listing the various extensions people use if I ever dig into this:

Dittach: https://chrome.google.com/webstore/detail/dittach/nckdidfgpjgjblkhloeecdmofhgphkmm?hl=en

@leggett

This comment has been minimized.

@leggett

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2019

Clearbit Connection: https://chrome.google.com/webstore/detail/clearbit-connect-supercha/pmnhcgfcafcnkbengdcanjablaabjplo

Change what I monitor as they are leaving the side-bar parent div as display:none but somehow still getting it to show.

@leggett

This comment has been minimized.

@aleemstreak

This comment has been minimized.

Copy link

commented Apr 28, 2019

We (Streak, a gmail extension) make the InboxSDK and we'd be happy to help make all the Gmail extensions that use the SDK be compatible with Simplify.

In fact we made the SDK so that all these gmail extensions don't stomp all over each other - it powers some of the more popular gmail extensions:
Dropbox: https://chrome.google.com/webstore/detail/dropbox-for-gmail/dpdmhfocilnekecfjgimjdeckachfbec?hl=en
Hubspot: https://chrome.google.com/webstore/detail/hubspot-sales/oiiaigjnkhngdbnoookogelabohpglmd?hl=en
Streak: https://chrome.google.com/webstore/detail/streak-crm-for-gmail/pnnfemgpilpdaojpnkjdgfgbnnjojfik?hl=en-US

@dragoncalledk

This comment has been minimized.

Copy link
Author

commented Apr 29, 2019

Meh, totally understand what you're saying and think you've outlined a reasonable approach. I actually love the new Gmail and DESPISED Inbox, so this is far from a major issue. If it's a plugin that just works reliably with vanilla Gmail, I think that's really reasonable. Thanks for your reply and your work!

@leggett

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2019

I still plan to work on this... it just isn't high on my list.

@leggett leggett reopened this Apr 29, 2019

@leggett

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2019

In fact, I'm more inclined now that I understand there is a single system I can integrate with (InboxSDK) to not mess up multiple extensions. It also fits with some of the work I'm considering to better support large displays.

@thob

This comment has been minimized.

Copy link

commented May 1, 2019

This extensions, Collabspot for SugarCRM, is essential for me https://chrome.google.com/webstore/detail/collabspot-sugarcrm-7-and/abolmnkelhknafibhnhnlgbhpoecimkm - it's not even visible in the hover
Update: It's actually visible under certain conditions, it's either the number of extensions then or an interference.

@anthonysexton

This comment has been minimized.

Copy link

commented May 14, 2019

@mfoucher

This comment has been minimized.

Copy link

commented May 14, 2019

We have confirmed that Mixmax, Mailtrack and Boomerang are having this issue with the extension.

@leggett

This comment has been minimized.

Copy link
Owner

commented May 15, 2019

I've started working on this.

Update: I looked at Boomerang, MixMax, Mailtrack, Streak in depth. I also looked at Dropbox and HubSpot Sales but they don't break Simplify, so I focused on the first 4.

  • I'm detecting the presence of these 4 extensions, setting state under html.simpl.otherExtensions and caching state under localStorage.simplify[u].otherExtensions
  • I've got Boomerang's pause inbox button fully hiding when the nav is closed, visible when the nav is open
  • I am hiding the app bar menu icons for Boomerang, MixMax, Mailtrack, and Streak - confirmed this prevents them from breaking search with Simplify on BUT, since I haven't added a way to get to those icons, I'm not comfortable releasing it in this state yet.

My plan is to do with these icons as I do with the Google App Switcher -- show them all when you hover over the profile pic. I might add a little left arrow on the profile pic to better hint at this functionality. The real beast is going to be around triggering showing/hiding the tray correctly as these icons are not uniformly inserted into the DOM. So this may still be a week or so from being fixed.

Question to those here: Should I go ahead and push this out so these extensions don't break Simplify (and instead, Simplify will break them sort of)? Or should I wait until I have my plan fully implemented?

@anthonysexton

This comment has been minimized.

Copy link

commented May 15, 2019

I can only talk to MixMax as that's the only one I use from that list but there is still a way to search, even when things don't lay out correctly. Given that, I'd be happy to wait until your plan was fully implemented as it seems like the right thing to do, rather than sending a potential heap of support requests the other way!

@leggett

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.