Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Rainbow channel effect #46

Closed
Legion2 opened this issue Oct 19, 2019 · 2 comments · Fixed by #78
Closed

Implement Rainbow channel effect #46

Legion2 opened this issue Oct 19, 2019 · 2 comments · Fixed by #78
Assignees
@Legion2
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
0.9.0

Comments

@Legion2
Copy link
Owner

Legion2 commented Oct 19, 2019

iCUE 3.19 or 3.20 added the Rainbow Channel lighting effect for HW Playback for fans and strips. This effects use the Group mode 0x00 (GROUP_MODE_Rainbow_Wave) and therefore looks like a Rainbow Wave in the protocol, but with ledCount of 96. Even with lighting strips with max 60 leds the ledCount is set to 96. This cause a crash (buffer overflow) in CLP.
@Legion2 Legion2 added bug Something isn't working enhancement New feature or request labels Oct 19, 2019
@Legion2 Legion2 modified the milestones: 1.0.0, 0.7.0 Oct 19, 2019
@Legion2 Legion2 self-assigned this Oct 19, 2019
@Legion2 Legion2 added the help wanted Extra attention is needed label Nov 14, 2019
@Legion2
Copy link
Owner Author

Legion2 commented Nov 14, 2019

The buffer overflow was fixed but i don't know how to detect Rainbow channel effect set by iCUE, it looks like the Rainbow Wave effect.

@Legion2 Legion2 removed the bug Something isn't working label Nov 14, 2019
@Legion2 Legion2 modified the milestones: 0.7.0, 0.8.0 Nov 14, 2019
@Legion2 Legion2 modified the milestones: 0.8.0, 1.0.0 Nov 28, 2019
@Legion2 Legion2 mentioned this issue Dec 2, 2019
Merged
@Legion2
Copy link
Owner Author

Legion2 commented Dec 2, 2019

Rainbow channel effect now works with #78 but the standard Rainbow wave now looks also like the Rainbow channel effect.

@Legion2 Legion2 modified the milestones: 1.0.0, 0.8.0, 0.9.0 Dec 2, 2019
@Legion2 Legion2 mentioned this issue Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Legion2 Legion2

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Improve hw playback Legion2/CorsairLightingProtocol
1 participant
@Legion2