Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arguments in <todo> lost after click on checkbox #16

Closed
runout-at opened this issue May 14, 2014 · 4 comments
Closed

arguments in <todo> lost after click on checkbox #16

runout-at opened this issue May 14, 2014 · 4 comments

Comments

@runout-at
Copy link
Collaborator

@runout-at runout-at commented May 14, 2014

the new start/due date functionality works, as long as nobody touches the checkbox.
if the checkbox is clicked, the dates will disappear.

i don't know how the ckeckbox click works, so i can't fix this.
can somebody help please!

@runout-at
Copy link
Collaborator Author

@runout-at runout-at commented May 15, 2014

the same problem appears with other arguments added to the tag.
just added functionality to have multiple users in one todo.

on checkbox checking all args will be lost. only the first user survives.

Loading

@runout-at runout-at changed the title start/due deleted after click on checkbox arguments in <todo> lost after click on checkbox May 15, 2014
@einhirn
Copy link
Collaborator

@einhirn einhirn commented Jun 10, 2014

problem lies in "_buildTodoTag" - it needlessly(?) parses the todo tag and only keeps known elements instead of just adding/removing the "#" sign if checked/unchecked...

Loading

runout-at added a commit that referenced this issue Jun 10, 2014
function _buildTodoTag not working with new options see issue #16
@runout-at
Copy link
Collaborator Author

@runout-at runout-at commented Jun 10, 2014

thanks for that information. i tried to fix this by a simple regex insead of parsing for each element inside the tag.
please check for side effects. and comment!
c34903f

Loading

@runout-at
Copy link
Collaborator Author

@runout-at runout-at commented Jun 10, 2014

sorry, there was a small bug, adding an additional ">". fixed: 960dabe#diff-3c55f5ee8584e7fd6e98541d4ee3f92d

Loading

@runout-at runout-at closed this Jun 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants