New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source roots to PyLint process #10

Open
bivald opened this Issue Sep 4, 2018 · 3 comments

Comments

2 participants
@bivald

bivald commented Sep 4, 2018

Is your feature request related to a problem? Please describe.
When running PyLint I get a lot of "unable to import module XYZ" which are actually my own source code folders.

Describe the solution you'd like
It would be awesome if it would automatically add your source roots (from your project) to the PYTHONPATH.

Describe alternatives you've considered
Modifying the pylint script to add the environments

Additional context
Add any other context or screenshots about the feature request here.

@leinardi

This comment has been minimized.

Show comment
Hide comment
@leinardi

leinardi Sep 4, 2018

Owner

OK, sorry for the silly questions but, as I stated before, my background is Java and not Python:

  1. Is your request somehow related to #7 ?
  2. My fix for #7 was to use the PyCharm Python interpreter to run Pylint, can this change fix also this issue?
  3. If the answer for 2. is no, what should be done to actually fix this?
  4. Can you provide a sample project where I can reproduce the issue?
Owner

leinardi commented Sep 4, 2018

OK, sorry for the silly questions but, as I stated before, my background is Java and not Python:

  1. Is your request somehow related to #7 ?
  2. My fix for #7 was to use the PyCharm Python interpreter to run Pylint, can this change fix also this issue?
  3. If the answer for 2. is no, what should be done to actually fix this?
  4. Can you provide a sample project where I can reproduce the issue?
@bivald

This comment has been minimized.

Show comment
Hide comment
@bivald

bivald Sep 5, 2018

It’s similar to #7, but it doesn’t concern the packages included in virtualenv but the sources marked as source folders. I will make a reproducible sample, and make sure it’s not me who is missing something. It’s also possible that #7 does fix it so I will try it.

My problem was that pylint don’t find my sources, so it lints the files but all of my imports of my own package gives error).

Might be an error on my part as well :)

bivald commented Sep 5, 2018

It’s similar to #7, but it doesn’t concern the packages included in virtualenv but the sources marked as source folders. I will make a reproducible sample, and make sure it’s not me who is missing something. It’s also possible that #7 does fix it so I will try it.

My problem was that pylint don’t find my sources, so it lints the files but all of my imports of my own package gives error).

Might be an error on my part as well :)

@leinardi

This comment has been minimized.

Show comment
Hide comment
@leinardi

leinardi Sep 14, 2018

Owner

Hi @bivald, could you please test v0.10.0 and let me know if it fixes this issue?

Owner

leinardi commented Sep 14, 2018

Hi @bivald, could you please test v0.10.0 and let me know if it fixes this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment