Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #207

Merged
merged 14 commits into from Jun 2, 2016
Merged

Support Python 3 #207

merged 14 commits into from Jun 2, 2016

Conversation

@singingwolfboy
Copy link
Member

@singingwolfboy singingwolfboy commented May 6, 2016

Fixes #142. Depends on #205 and #206 -- and I'm happy to pull some of these changes out into other, smaller pull requests if you prefer.

@mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented May 6, 2016

Neat! I will try to review it over the weekend.

@singingwolfboy singingwolfboy force-pushed the singingwolfboy:py3 branch from 6a59978 to 695d6c2 May 6, 2016
@singingwolfboy
Copy link
Member Author

@singingwolfboy singingwolfboy commented May 6, 2016

@mitsuhiko: Fantastic! Now that you've merged the other PRs I made, I've rebased this branch onto the latest version of master, so there are fewer commits to look at.

As you can see from Travis, all the automated tests pass. In addition, I tried running lektor quickstart and lektor server on Python 3, and discovered a few more bugs which I also fixed, but that indicates lack of coverage in the test suite. I added two small new tests, but I wasn't sure how to test the larger stuff. Please pay special attention to the last few commits in this PRs, since those are the ones that fix bugs that do not have associated automated tests. (I'd be happy to write more automated tests, if I had someone to guide me through how to write the necessary tests.)

Once this is working properly on Python 3, I'm going to try building my own Lektor-powered site. If I do so successfully, then I volunteer to maintain Python 3 support for Lektor, since I'll be doing it anyways. :)

hroncok added a commit to fedora-python/portingdb that referenced this pull request May 6, 2016
@singingwolfboy
Copy link
Member Author

@singingwolfboy singingwolfboy commented May 10, 2016

@mitsuhiko: Any update on this pull request?

@mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented May 31, 2016

Hi @singingwolfboy. Sorry i was so busy with other things. Any chance we could talk about this PR this week on gitter/irc?

@singingwolfboy
Copy link
Member Author

@singingwolfboy singingwolfboy commented Jun 2, 2016

@mitsuhiko has given me commit rights on the project, so that I can support Lektor on Python 3. Let me know if I've missed anything! Thanks, @mitsuhiko!

@singingwolfboy singingwolfboy merged commit 7a9d1b5 into lektor:master Jun 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sybrenstuvel
Copy link

@sybrenstuvel sybrenstuvel commented Jun 9, 2017

When will we see a release that includes this? The last release is over a year old.

@tariquesani
Copy link
Member

@tariquesani tariquesani commented Jun 9, 2017

Wish there could be a fixed date. The development is stalled at the moment.

@austinbutler
Copy link

@austinbutler austinbutler commented Feb 6, 2018

So with this merged and Lektor 3.1 released, does that mean Python 3 is supported?

@nixjdm
Copy link
Member

@nixjdm nixjdm commented Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants