New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `.git` to the end of the ghpages+https URL #240

Merged
merged 1 commit into from Jul 7, 2016

Conversation

Projects
None yet
2 participants
@singingwolfboy
Copy link
Member

singingwolfboy commented Jul 6, 2016

This fixes a problem that @pybee and others have had when trying to deploy to a ghpages+https URL. Apparently the .git was getting left off the URL, which meant that Git couldn't find the repository, which caused everything to fail. @mitsuhiko, can you review this?

To build against this branch on Travis CI, edit your .travis.yml file to change this line:

install: "pip install lektor"

to this line:

install: "pip install git+https://github.com/singingwolfboy/lektor.git@fix-ghpages-https-deploy#egg=lektor"

Note that once this pull request is merged, I will probably delete this branch from my fork of the repo. When that happens, that install line will fail, but you'll be able to replace singingwolfboy/lektor with lektor/lektor and remove @fix-ghpages-https-deploy from the URL.

singingwolfboy referenced this pull request in lektor/lektor-website Jul 6, 2016

@singingwolfboy singingwolfboy force-pushed the singingwolfboy:fix-ghpages-https-deploy branch from 0fe4812 to 7ec2a28 Jul 6, 2016

@singingwolfboy singingwolfboy referenced this pull request Jul 6, 2016

Closed

Debug auto deploy #12

@mitsuhiko

This comment has been minimized.

Copy link
Member

mitsuhiko commented Jul 6, 2016

Do you know in which circumstances the .git is necessary? Because from what I can tell it works without here.

@singingwolfboy

This comment has been minimized.

Copy link
Member

singingwolfboy commented Jul 6, 2016

No, I don't know what determines whether it's necessary or not. At first, I thought the problem might have been related to the version of Git, and that newer ones could handle it without the .git at the end but older ones couldn't. That turned out to not be the case. All I know is that Travis seems to need that .git on the end.

@mitsuhiko mitsuhiko merged commit 50b5673 into lektor:master Jul 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mitsuhiko

This comment has been minimized.

Copy link
Member

mitsuhiko commented Jul 7, 2016

I should probably also get this on the 2.x maintenance branch.

nhanb added a commit to nhanb/sf-vietnam.com that referenced this pull request Sep 22, 2016

add .git to deploy target link
This is a fixed issue in lektor [1] but has not landed in the latest
release yet.

[1]: lektor/lektor#240

squiddy added a commit to unknown-horizons/unknown-horizons.github.io that referenced this pull request Mar 7, 2017

Use different lektor version to fix ghpages deployment
It's an issue in lektor (see [1]). For an example configuration see [2].

Unfortunately there was no new release after the fix was merged.

[1] lektor/lektor#240
[2] https://github.com/pybee/pybee.github.io/blob/lektor/.travis.yml

vitorbaptista added a commit to okfn/2018.okfestival.org that referenced this pull request May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment