New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text_factory for PY2 #299

Merged
merged 4 commits into from Oct 29, 2016

Conversation

Projects
None yet
2 participants
@item4
Contributor

item4 commented Oct 13, 2016

Read the #243 for more info.

fix #243

Make text_factory for PY2
Read the #243 for more info.

fix #243
@singingwolfboy

This comment has been minimized.

Member

singingwolfboy commented Oct 21, 2016

This looks like a great solution, but it's hard to understand. I know that if I took a look a this code without understanding the problem, I wouldn't understand what these lines are supposed to achieve. Can you add a comment explaining what's going on here, and maybe add an automated test as well?

@item4

This comment has been minimized.

Contributor

item4 commented Oct 25, 2016

@singingwolfboy I made test. but I want to check by @mitsuhiko what he want to support multibyte fully. Old test case do not allow multibyte directory name.

@item4

This comment has been minimized.

Contributor

item4 commented Oct 25, 2016

I will add comments and tests case asap.


보낸 사람: David Baumgold notifications@github.com
보낸 날짜: 2016년 10월 21일 금요일 오후 10:19:58
받는 사람: lektor/lektor
참조: item4; Author
제목: Re: [lektor/lektor] Make text_factory for PY2 (#299)

This looks like a great solution, but it's hard to understand. I know that if I took a look a this code without understanding the problem, I wouldn't understand what these lines are supposed to achieve. Can you add a comment explaining what's going on here, and maybe add an automated test as well?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/299#issuecomment-255374550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAiLUP9QcC_6ZWld01xUJjKELZEtCyqSks5q2Lv-gaJpZM4KVyuJ.

@singingwolfboy

This comment has been minimized.

Member

singingwolfboy commented Oct 26, 2016

Thanks! Looks like you created a file called ättachemnt -- can you rename it to ättachment instead, so that it's spelled correctly?

@item4

This comment has been minimized.

Contributor

item4 commented Oct 26, 2016

fixed

@singingwolfboy

This comment has been minimized.

Member

singingwolfboy commented Oct 29, 2016

Great, thank you so much!

@singingwolfboy singingwolfboy merged commit 3d0bd9c into lektor:master Oct 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

go-bears added a commit to go-bears/lektor that referenced this pull request Nov 6, 2016

Make text_factory for PY2 (lektor#299)
Make sqlite text_factory for Python 2

So that we avoid problems with non-ASCII characters in file names.

skorokithakis added a commit to skorokithakis/lektor that referenced this pull request Feb 15, 2017

Make text_factory for PY2 (lektor#299)
Make sqlite text_factory for Python 2

So that we avoid problems with non-ASCII characters in file names.

nixjdm added a commit that referenced this pull request Jun 12, 2017

Make text_factory for PY2 (#299)
Make sqlite text_factory for Python 2

So that we avoid problems with non-ASCII characters in file names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment