Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes setup.cfg in plugin template #690

Open
wants to merge 1 commit into
base: master
from

Conversation

@georgeyk
Copy link

georgeyk commented Oct 2, 2019

Issue(s) Resolved

Fixes #634

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)
  • Link to corresponding documentation pull request for getlektor.com

Hey,

Unlike the other files in the plugin template, setup.cfg does not include any dynamically set value.
I've updated existing tests, should I include a test for setup.cfg contents?

~ ✌️

@nixjdm

This comment has been minimized.

Copy link
Member

nixjdm commented Oct 3, 2019

Looks good to me! I'll merge this without a test. There are unrelated tests failing since pylint updated. I'll take a look at those in a few days and then merge this.

Thanks!

It also updates related tests to consider "setup.cfg" file existence.
@georgeyk georgeyk force-pushed the georgeyk:plugin-setupcfg branch from 61a7454 to f6a5572 Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.