Upgrade react-router #739
Merged
Upgrade react-router #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice. This is something I've wanted to do for a long time. I'll try to get this reviewed during next week. |
|
Sorry for the delay in handling this. It looks great! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues / Links
Ref #449
Description of Changes
This upgrades react-router to from version 3 to 5. This introduces quite a few changes to how the
<Route>components work. Instead of basically just registering routes, they now do the actual rendering. Also, there's now the<Prompt>component to prevent navigation.Also use function components or components only inheriting from
React.Componentin some places.